Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize GeoData full record based on usability test results #185

Merged
merged 1 commit into from
May 3, 2024

Commits on May 3, 2024

  1. Reorganize GeoData full record based on usability test results

    Why these changes are being introduced:
    
    Now that we've done usability testing, we have a better sense
    of what fields in the 'More information' section of the full
    record may be useful.
    
    Relevant ticket(s):
    
    * [GDT-283](https://mitlibraries.atlassian.net/browse/GDT-283)
    
    How this addresses that need:
    
    This moves each relevant field out of the 'more_info_geo' partial
    and into the 'record_geo' partial. The display of each field has
    been cleaned up a bit (e.g., removing subfield keys), and the
    fields are now in `p` tags or `ul` tags with their own headings.
    
    Since place names are duplicated as subjects, the locations field
    has been repurposed to show only geoshapes. This also required
    replacing the deprecated `geopoint` with `geoshape` in the
    TimdexRecord query string, and regenerating the record controller
    cassettes accordingly.
    
    Some record helper logic (and corresponding tests) that are no
    longer needed have also been removed.
    
    Side effects of this change:
    
    I'm not sure it's useful to display this metadata, particularly
    when we provide an affordance to download the source metadata
    and/or link to the source record. At some point, I'd like to have
    a broader conversation about whether we should include full records
    at all in TIMDEX UI. For now, I'm comfortable implementing this
    as requested.
    jazairi committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cfddc2d View commit details
    Browse the repository at this point in the history