Improve markup for contributors #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9291478300Details
💛 - Coveralls |
JPrevost
requested changes
May 30, 2024
| @@ -0,0 +1,5 @@ | |||
| <%= return if contributors.blank? %> | |||
|
|
|||
| <% contributors.uniq.map do |contributor| %> | |||
There was a problem hiding this comment.
Is .map doing something here I'm not understanding?
There was a problem hiding this comment.
Yeah, good call. It's probably a remnant of a previous iteration.
| <p class="authors truncate-list"> | ||
| <%= render partial: 'shared/authors', locals: { contributors: result_geo['contributors'] } %> | ||
| </p> | ||
| <span class="sr">Contributors: </span> |
There was a problem hiding this comment.
I think it would be a bit of a refactor to do this, so I don't think we should in this change... but if we changed result_geo to just be result wherever it came from we'd be able to remove some duplication and move the entire contributors logic into the shared partial instead of having geo/normal variants that are identical.
There was a problem hiding this comment.
Agreed on both counts.
JPrevost
approved these changes
May 30, 2024
Why these changes are being introduced: Authors are currently rendered within a `p` tag. This is not very semantically meaningful. Relevant ticket(s): * [GDT-284](https://mitlibraries.atlassian.net/browse/GDT-284) How this addresses that need: This refactors the contributors section to a partial and renders contributors as an unordered list. It is the same changeset that was introduced in #191, but without displaying the contributor type, which UXWS has deemed unnecessary at this time. Side effects of this change: None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Authors are currently rendered within a
ptag. This is not very semantically meaningful.Relevant ticket(s):
How this addresses that need:
This refactors the contributors section to a partial and renders contributors as an unordered list. It is the same changeset that was introduced in #191, but without displaying the contributor type, which UXWS has deemed unnecessary at this time.
Side effects of this change:
None.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
N/A
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing