Skip to content

Commit

Permalink
Add 4th option based on PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ehanson8 committed Feb 16, 2024
1 parent fc423fa commit dd2567e
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions docs/adrs/0002-field-for-data-type-form-information.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,28 @@ Cons:
* would require reworking the transformations + re-indexing any sources that use `literary_form`
* nested field type, a bit harder to query for aggregations

#### Option 4 - Use `file_formats` for current `format` values and `format` for Data Type values

In this approach, the current `MITAardvark.format` values would shift to the previously unused `MITAardvark.file_formats` property and the Data Type values would be stored in `MITAardvark.format`

Example:
```json

{
"content_type": "Geospatial data",
"format": ["Polygon", "Point", "Raster", "Image"],
"file_formats": ["Shapefile", "TIFF", "GeoTIFF", "JPEG"]
}
```

Pros:
* does not require TIMDEX data model changes

Cons:
* `file_formats` has previously only stored MIME type values, such as `application/pdf`
* may require explanation of the facet mapping in the UI documentation
* may require updates of other transform classes for consistency

## Decision

It is proposed to move forward with **Option 3: Create new, multivalued objects field `form`; collapse `literary_form` into this**.
Expand Down

0 comments on commit dd2567e

Please sign in to comment.