get_edition

tests/sources/xml/test_marc.py

@@ -1132,6 +1132,43 @@ def test_get_dates_transforms_correctly_if_char_positions_blank():
     assert Marc.get_dates(source_record) is None
 
 
+def test_get_edition_success():
+    source_record = create_marc_source_record_stub(
+        datafield_insert=(
+            """
+            <datafield tag="250" ind1=" " ind2=" ">
+                <subfield code="a">9th ed. /</subfield>
+                <subfield code="b">Nick Ray ... [et al.].</subfield>
+            </datafield>
+            <datafield tag="250" ind1=" " ind2=" ">
+                <subfield code="a">Unabridged.</subfield>
+            </datafield>
+            """
+        )
+    )
+    assert (
+        Marc.get_edition(source_record) == "9th ed. / Nick Ray ... [et al.]. Unabridged."
+    )
+
+
+def test_get_edition_transforms_correctly_if_fields_blank():
+    source_record = create_marc_source_record_stub(
+        datafield_insert=(
+            """
+            <datafield tag="250" ind1=" " ind2=" ">
+                <subfield code="a"></subfield>
+            </datafield>
+            """
+        )
+    )
+    assert Marc.get_edition(source_record) is None
+
+
+def test_get_edition_transforms_correctly_if_fields_missing():
+    source_record = create_marc_source_record_stub()
+    assert Marc.get_edition(source_record) is None
+
+
 def test_marc_record_missing_leader_skips_record(caplog):
     marc_xml_records = Marc.parse_source_file(
         "tests/fixtures/marc/marc_record_missing_leader.xml"

transmogrifier/sources/xml/marc.py

@@ -64,13 +64,7 @@ def get_optional_fields(self, source_record: Tag) -> dict | None:
         fields["dates"] = self.get_dates(source_record)
 
         # edition
-        edition_values = []
-        for datafield in source_record.find_all("datafield", tag="250"):
-            if edition_value := self.create_subfield_value_string_from_datafield(
-                datafield, "ab", " "
-            ):
-                edition_values.append(edition_value)  # noqa: PERF401
-        fields["edition"] = " ".join(edition_values) or None
+        fields["edition"] = self.get_edition(source_record)
 
         # file_formats
 
@@ -860,6 +854,19 @@ def get_dates(cls, source_record: Tag) -> list[timdex.Date] | None:
             return [timdex.Date(kind="Publication date", value=publication_year)]
         return None
 
+    @classmethod
+    def get_edition(cls, source_record: Tag) -> str | None:
+        edition_values = [
+            edition_value
+            for datafield in source_record.find_all("datafield", tag="250")
+            if (
+                edition_value := cls.create_subfield_value_string_from_datafield(
+                    datafield, "ab", " "
+                )
+            )
+        ]
+        return " ".join(edition_values) or None
+
     @staticmethod
     def get_main_titles(xml: Tag) -> list[str]:
         """