Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdt 54 aardvark transform #108

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Gdt 54 aardvark transform #108

merged 5 commits into from
Dec 18, 2023

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    5f061bb View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. GDT-54 Create Aardvark transform

    Why these changes are being introduced:
    * This is the initial structure for the Aardvark transform class. The class will be expanded with new methods in subsequent commits.
    
    How this addresses that need:
    * Add jsonlines to Pipfile
    * Add fixtures for aardvark and generic JSONLines files
    * Update argument type hinting for Transformer and JsonTransformer classes to clarify expected content types
    * Update JsonTransformer.parse_source_file method to use jsonlines library
    * Add Aardvark class with get_main_titles, get_source_record_id, record_is_deleted (in progress), get_optional_fields (in progress), and get_subjects methods and corresponding unit tests
    
    Side effects of this change:
    * None
    
    Relevant ticket(s):
    * https://mitlibraries.atlassian.net/browse/GDT-54
    ehanson8 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1cfb37b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8edb2cf View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Updates based on discussion in PR #108

    * Update json_records fixture to aardvark_records for more accurate unit tests
    * Rename Aardvark > MITAardvark to unify terminology across repos
    * Update get_main_titles method to reflect it is a required field
    * Update Aardvark method docstrings to provide greater context
    * Add Transformer._transform method to minimize code duplication between JsonTransformer and XmlTransformer methods
    ehanson8 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    71e9ec1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d832074 View commit details
    Browse the repository at this point in the history