GDT-54 Address mismatches with OpenSearch mapping #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: After an MITAardvark transformation was mostly completed, a couple of small bugs were discovered when attempting to index the transformed TIMDEX records into OpenSearch. This commit adddresses those bugs, both full fixes and workarounds, to allow continued pipeline testing and improvements to the MITAardvark transformation. How this addresses that need: * adds kind property to Dates and Identifiers * set get_locations() field method to return empty list until mapping approach confirmed Side effects of this change: * Anticipating successful indexing attempts from transformed records Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-54
ghukill
force-pushed
the
GDT-54-workarounds-and-bug-fixes
branch
from
79e553f
to
6a97912
Compare
ehanson8
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful background context
After an MITAardvark transformation was mostly completed, a couple of small bugs were discovered when attempting to index the transformed TIMDEX records into OpenSearch. This commit adddresses those bugs, both full fixes and workarounds, to allow continued pipeline testing and improvements to the MITAardvark transformation.
How this addresses that need:
kindproperty to Dates and Identifierslocations.valueinstead oflocations.geodataHow can a reviewer manually see the effects of these changes?
Not readily testable as the StepFunction pipeline is not fully formed to attempt indexing of these documents. But, these changes have been confirmed via a local solution that applied these updates to the transformation process, then successfully indexed documents into OpenSearch.
What are the relevant tickets?
Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES | NO