Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Aardvark field method refactor #199

Merged
merged 3 commits into from
Jul 19, 2024

Commits on Jul 15, 2024

  1. Complete Aardvark field method refactor

    Why these changes are being introduced:
    * Update Aardvark class to use current field method conventions for the remaining fields
    
    How this addresses that need:
    * Add field methods and associated private methods for format, identifiers, languages, links, locations, notes, provider, publishers, rights, subjects, and summary
    * Refactor get_links and get_source_link method to avoid error if links field is None
    * Update unit tests with current conventions
    
    Side effects of this change:
    * None
    
    Relevant ticket(s):
    * https://mitlibraries.atlassian.net/browse/TIMX-285
    ehanson8 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8b58824 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Updates based on discussion in PR # 199

    * Create submethods for get_rights
    * Rename get_dates submethods for consistency
    ehanson8 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5b086ee View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Further updates based on discussion in PR #199

    * Refactor get_source_link method
    * Update dependencies to address new safety vulnerability
    * Updates to address linting errors
    * Add XMLTransformer.record_is_deleted unit test
    ehanson8 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3f67bcb View commit details
    Browse the repository at this point in the history