Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create find_proxy function for local outcome #519

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laleoarrow
Copy link

@laleoarrow laleoarrow commented May 19, 2024

Summary

This PR adds a local proxy SNP search function to the TwoSampleMR package. This function allows users to find proxy SNPs locally with or without relying on external databases, enhancing the package's usability and functionality.

Details

  • Added a new script find_proxy.R under the R directory.
  • Implemented a function to search for proxy SNPs for local data, which is not available in the current tsmr package.
  • Updated example use in find_proxy.R, which can easily be used in line with tsmr pipeline.

Motivation

Finding proxy SNPs is a critical step in many MR analyses. By providing a local search function, we can support users who have specific datasets or need offline capabilities.

Testing

Tested the function with several iv datasets in our case to ensure accuracy and performance, which are documented in the comments within the added script.

Additional Notes

First of all, totally big fan of your team and the great work you do. This PR adds only one file, find_proxy.R, under the R directory. This should help the maintainer easily check and review the changes. If this idea is accepted but requires more details, please feel free to contact me via GitHub. I am happy to contribute further to the TwoSampleMR package.

### Summary
This PR adds a local proxy SNP search function to the TwoSampleMR package. This function allows users to find proxy SNPs locally with or without relying on external databases, enhancing the package's usability and functionality.

### Details
- Added a new script `find_proxy.R` under the `R` directory.
- Implemented a function to search for proxy SNPs for local data, which is not available in the current tsmr package.
- Updated example use in `find_proxy.R`, which can easily be used in line with tsmr pipeline.

### Motivation
Finding proxy SNPs is a critical step in many MR analyses. By providing a local search function, we can support users who have specific datasets or need offline capabilities.

### Testing
Tested the function with several example datasets to ensure accuracy and performance, which are documented in the comments within the added script.

### Additional Notes
First of all, totally big fan of your team and the great work you do. This PR adds only one file, `find_proxy.R`, under the `R` directory. This should help the maintainer easily check and review the changes. If this idea is accepted but requires more details, please feel free to contact me via GitHub. I am happy to contribute further to the TwoSampleMR package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant