Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate killscore by kill assists, kills, deaths and HPs healed #1171

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

farooqkz
Copy link
Contributor

@farooqkz farooqkz commented Jul 3, 2023

This was suggested several times. The current algorithm only counts kills and deaths. But we know kill assists are just as important. And a medic-knight combination can be very dangerous.

@LoneWolfHT
Copy link
Member

You just broke it again. It's fine if the maps commit is broken locally, the main repo knows which one to use

You can fix it by rebasing and dropping the commit

There are also conflicts with the PR again unfortunately

@farooqkz
Copy link
Contributor Author

@LoneWolfHT Ready to merge :)

And let me know if you want it on the experimental server.

@farooqkz
Copy link
Contributor Author

farooqkz commented Apr 7, 2024

@LoneWolfHT Status?

@LoneWolfHT
Copy link
Member

You could run it on the test server, it'll be a while before I can review it

@LoneWolfHT
Copy link
Member

This needs to be well-tested on a test server, or at least merged after a ranked reset

@LoneWolfHT LoneWolfHT added the 🏗️ Ranked Reset Queue Can only be merged after the next ranking reset label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants