Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature to steal from enemy teamchest while it is open in classic #1321

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add feature to steal from enemy teamchest while it is open in classic #1321

wants to merge 5 commits into from

Conversation

farooqkz
Copy link
Contributor

@farooqkz farooqkz commented Jun 29, 2024 •
edited
Loading

  • This PR has been tested locally

@farooqkz farooqkz mentioned this pull request Jun 29, 2024
Closed
@farooqkz farooqkz requested a review from LoneWolfHT June 30, 2024 13:19
@farooqkz farooqkz marked this pull request as ready for review June 30, 2024 13:19
@farooqkz
Copy link
Contributor Author

Alright, this long awaiting feature finally would get added to CTF. It's working however when the close formspec event is fired, my function gets executed but player name won't get removed from the table for reasons I can't find now(due to lack of enough sleep?). @LoneWolfHT You are welcome to fix and merge it. The line is https://github.com/MT-CTF/capturetheflag/pull/1321/files#diff-34cefccf3df0840765bb2561068d664b0eed93136d8983bf0afe27a96587c234R133

BTW, doors and chests have their own mod now. Because otherwise ctf_teams would depend on ctf_modebase and vice versa, thus making a circular dependency tree.

@farooqkz
Copy link
Contributor Author

farooqkz commented Jul 1, 2024

The problem has been solved. Ready for review and merge.

@LoneWolfHT
Copy link
Member

Adding this to classic makes me a little wary, since it wasn't a feature in CTFv1. Where was the discussion on this again?

@farooqkz
Copy link
Contributor Author

https://discord.com/channels/447819017391046687/448136308108296213/1009004805823414342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneWolfHT LoneWolfHT Awaiting requested review from LoneWolfHT

Assignees
No one assigned
Labels
Feature ⭐ ⚙️ Classic Ready for review 🎉 Ready for Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farooqkz @LoneWolfHT