Improve kkt creation on GPUs #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 68.75% 68.75% -0.01%
==========================================
Files 42 41 -1
Lines 4622 4621 -1
==========================================
- Hits 3178 3177 -1
Misses 1444 1444 ☔ View full report in Codecov by Sentry. |
frapac
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Good we can accelerate the KKT creation on the GPU, I noticed too that this was one of our bottleneck.
I have only minor comments. As a general rule of thumb, I would be in favor of adopting a proper naming convention for the GPU kernels. I am trying to follow the guideline:
@kernel! _do_operation_kernel!(modified_args, @Const(constant_args))but I would welcome any other better suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves KKT System creation on GPUs.
For some parts, we've been calling CPU versions. We introduce native GPU code for them.