Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup when Obsidian is closed by the user #72

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Cleanup when Obsidian is closed by the user #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/jupyter-obsidian.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileSystemAdapter, Notice, Plugin, normalizePath, setIcon, setTooltip } from "obsidian";
import { FileSystemAdapter, Notice, Plugin, Tasks, Workspace, normalizePath, setIcon, setTooltip } from "obsidian";
import { JupyterEnvironment, JupyterEnvironmentError, JupyterEnvironmentEvent, JupyterEnvironmentStatus, JupyterEnvironmentType } from "./jupyter-env";
import { EmbeddedJupyterView } from "./ui/jupyter-view";
import { DEFAULT_SETTINGS, JupyterSettings, JupyterSettingsTab, PythonExecutableType } from "./jupyter-settings";
Expand Down Expand Up @@ -55,6 +55,11 @@ export default class JupyterNotebookPlugin extends Plugin {
this.registerExtensions(["ipynb"], "jupyter-view");
this.addSettingTab(new JupyterSettingsTab(this.app, this));

// Try to unload when Obsidian is closed by the user/the OS
this.app.workspace.on('quit', async (_tasks: Tasks) => {
await this.onunload();
});

this.announceUpdate();
}

Expand Down