chore: check for version and unittests

backend/application/import_observations/parsers/ocsf/parser.py

@@ -8,6 +8,8 @@
     StatusID,
 )
 from py_ocsf_models.events.findings.finding import ActivityID
+from rest_framework.exceptions import ValidationError
+from semver import Version
 
 from application.core.models import Observation
 from application.core.types import Severity
@@ -56,6 +58,22 @@ def check_format(self, file: File) -> tuple[bool, list[str], dict | list]:
                     {},
                 )
 
+            tool_name = (
+                first_element.get("metadata", {}).get("product", {}).get("name", "")
+            )
+            tool_version = (
+                first_element.get("metadata", {}).get("product", {}).get("version", "")
+            )
+            if tool_name == "Prowler":
+                if not tool_version or Version.parse(tool_version) < Version.parse(
+                    "4.5.0"
+                ):
+                    return (
+                        False,
+                        ["Prowler is only supported with version 4.5.0 and above"],
+                        {},
+                    )
+
         return True, [], data
 
     def get_observations(self, data: list) -> list[Observation]:
@@ -108,7 +126,7 @@ def get_observations(self, data: list) -> list[Observation]:
 
                     observation.unsaved_references = get_references(finding)
             except Exception as e:
-                logger.warning("Error parsing OCSF finding: %s", str(e))
+                raise ValidationError(f"Error parsing OCSF finding: {str(e)}")
 
         return observations
 

backend/pyproject.toml

@@ -56,8 +56,9 @@ jira = "3.8.0"  # https://github.com/pycontribs/jira
 inflect = "7.4.0"  # https://github.com/jaraco/inflect
 validators = "0.34.0"  # https://github.com/python-validators/validators
 cvss = "3.3"  # https://github.com/RedHatProductSecurity/cvss
-jsonpickle = "3.4.1"  # https://github.com/jsonpickle/jsonpickle
-py-ocsf-models="0.2.0"  # https://github.com/prowler-cloud/py-ocsf-models 
+jsonpickle = "3.4.2"  # https://github.com/jsonpickle/jsonpickle
+py-ocsf-models = "0.2.0"  # https://github.com/prowler-cloud/py-ocsf-models
+semver = "3.0.2"  # https://github.com/python-semver/python-semver
 
 # Development dependencies
 # ------------------------------------------------------------------------------

backend/unittests/import_observations/parsers/ocsf/files/other_finding.json

@@ -5,7 +5,7 @@
             "product": {
                 "name": "Prowler",
                 "vendor_name": "Prowler",
-                "version": "4.3.5"
+                "version": "4.5.5"
             },
             "version": "1.2.0"
         },