-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/3637/add apply button #3795
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, I just have a couple of suggestions that might make this more intuitive.
- Gray out and disable the Apply button when there are no changes, enable it when there is. That makes it clear when something changed and you have to apply.
- The text on hover of the delete button is Remove map even when the button is restoring it.
- Instead of a + icon we can use an undo, maybe it's clearer that it undoes the "delete".
Quality Gate passed for 'CodeCharta Visualization'Issues Measures |
Quality Gate passed for 'CodeCharta Analysis'Issues Measures |
Add an apply button when selecting maps
Closes: #3637
Description
Added a button below the map selection.
Removing and changing the selection state of maps is only applied, if user clicks the apply button.
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs