Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: play sound effect when timer expires #398

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: play sound effect when timer expires #398

wants to merge 4 commits into from

Conversation

dostulataa
Copy link
Collaborator

Play sound effect when timer expires

Issue: #199

@dostulataa dostulataa requested a review from NearW April 25, 2024 11:55
NearW
NearW approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@NearW NearW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The sound is horrible though. Where did you get that from? Did you record your door bell? :D

@NearW NearW force-pushed the feature/199/timer_expired_sound branch from e43f877 to 061c477 Compare June 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NearW NearW NearW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dostulataa @NearW