Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to fetch terraform stdout for showing in UI. #78

Merged
merged 16 commits into from
Oct 21, 2024
Merged

Add methods to fetch terraform stdout for showing in UI. #78

merged 16 commits into from
Oct 21, 2024

Commits on Oct 16, 2024

  1. add method for fetching terraform stdout from UI

    @putmanoj
    putmanoj committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bf05f0f View commit details
    Browse the repository at this point in the history

  2. update comments

    @putmanoj
    putmanoj committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    48ef887 View commit details
    Browse the repository at this point in the history

  3. code review - use MiqTask to Job association

    @putmanoj
    putmanoj committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ab35fce View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. code review: raw_stdout_json is not required, raise NotImplementedError

    @putmanoj
    putmanoj committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    11d5159 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. remove raw_stdout_json, as don't need to support for 'json' stdout

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f1ddef8 View commit details
    Browse the repository at this point in the history

  2. return empty string(not nil) if no miq_task or job in miq_task or no … 

    …terraform_stack_id in job
    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2acad77 View commit details
    Browse the repository at this point in the history

  3. add test for Stack.raw_stdout : terraform runner without valid miq_task

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    553cfe9 View commit details
    Browse the repository at this point in the history

  4. move code fetching data from terraform_runner to private method

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c3c0643 View commit details
    Browse the repository at this point in the history

  5. add tests for #raw_stdout, when miq_task.job present

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f914e2f View commit details
    Browse the repository at this point in the history

  6. remove unnecessary require

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    92aaf35 View commit details
    Browse the repository at this point in the history

  7. miq_task definition in single line

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ab7c97f View commit details
    Browse the repository at this point in the history

  8. don't need to test here, if terraform_runner api is called

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3ff9628 View commit details
    Browse the repository at this point in the history

  9. use let instead of before in the test

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7185a41 View commit details
    Browse the repository at this point in the history

  10. remove setting stack.miq_task in before, setting in let

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    58727f0 View commit details
    Browse the repository at this point in the history

  11. don't need to return empty string, instead return nil, if terraform_r… 

    …unner_stack_data is not available
    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    77e70a9 View commit details
    Browse the repository at this point in the history

  12. add tests for raw_stdout_via_worker

    @putmanoj
    putmanoj committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    47707cc View commit details
    Browse the repository at this point in the history