First pass / rough draft of HTMLMapmlViewerElement.matchMedia API, #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prushforth
force-pushed
the
match-media
branch
from
49f37a9
to
a5e3c89
Compare
depends on media-query-parser and media-query-solver.
prefers-color-scheme,map-projection,map-zoom working up to the initial matches. Tbd if this will need modification to support dynamic evaluation of map properties to support attaching event handlers. Not yet determined: how to implement map-extent support, because media features are all either discrete or range types, and while it may be possible to implemnent a bbox using four corner values as the pre-determined corners of the bbox, it is less clear how to represent a bbox as a media feature value, which does not typically contain commas.
(relies on M.options.contentPreference being an array).
allowing dynamic use of the object in event handlers. Add window.matchMedia query + event listener for color-scheme changes, allows map to adapt without having to shake it.
prushforth
force-pushed
the
match-media
branch
from
872d89f
to
a6412d0
Compare
…age, not navigator.languages, because other values aren't of use).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on media-query-parser and media-query-solver.