Support replacing geometry for nodes and ways #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpoole
force-pushed
the
replace_geometry
branch
2 times, most recently
from
0e8e11c
to
5403f53
Compare
This add supports for two different operations that however traditionally run under the same name: - replacing a node with a way, maintaining history as far as possible and adding tags from the node to the way. - using the position of nodes in a way to to recreate the same geometry in an existing way. Resolves #1053
simonpoole
force-pushed
the
replace_geometry
branch
from
5403f53
to
3548c4e
Compare
This adds code to show a modal in the style of the tag conflict one if we needed to extract a tagged node and a preference to determine the distance at which we start doing that.
simonpoole
force-pushed
the
replace_geometry
branch
from
664a9e9
to
632d630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add supports for two different operations that however traditionally run under the same name:
replacing a node with a way, maintaining history as far as possible and adding tags from the node to the way.
using the position of nodes in a way to to recreate the same geometry in an existing way.
Resolves #1053