Issue47 drawborehole

[j-c-cook]

Changes:

• Incorporates Massimo Cimmino _check_geometry method d084842
• Creates example for visualizing a borehole
  • Initial file creation f13edab
  • Add borehole top view plot ba3435a
  • Reduce line width of pipe lines b10059f

[MassimoCimmino]

@j-c-cook This looks great.

I made some adjustments to the example template and added documentation files on https://github.com/MassimoCimmino/pygfunction/tree/issue47_drawBorehole_j-c-cook.

I see git tracks changes on 72 files on this pull request while only 3 Python files saw changes. My searches bring me https://stackoverflow.com/questions/1580596/how-do-i-make-git-ignore-file-mode-chmod-changes/1580644#1580644. This should probably be settled before merging into master.

[j-c-cook]

The stackoverflow answer https://stackoverflow.com/a/1580644/11637415 worked great for how to ignore file mode chmod changes. I was unaware of why that was going on. Its a good thing you requested I revert those changes. Does it now look okay in that regard?

I merged your https://github.com/MassimoCimmino/pygfunction/tree/issue47_drawBorehole_j-c-cook additions. I have added a borehole resistance computation, for during design it is nice to know both geometry is proper and idea of borehole resistance.

What do you think about the addition of the borehole resistance calculation?

Perhaps the file should be named custom_borehole_design...

[MassimoCimmino]

It looks like the changed files successfully disappeared from the diff.

I fully agree with the calculation of the resistance.

I am unsure if design is better than definition since the design implies the choice of dimensions/material/etc based on external constraints.

I will review on last time once you confirm you are done with the changes, then I will update the documentation files (*.rst) and it should be ready to merge!

[j-c-cook]

Thanks.

For now I am done with the custom_borehole_definition example. I like definition; I agree it is more applicable. I've started a branch related to this, and will probably modify the example file to use those custom inputs.

I think this issue is completed once you have made the modifications you would like to.