Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue36 coaxial pipes #79

Merged
merged 47 commits into from
Aug 27, 2021

Commits on Nov 1, 2018

  1. Configuration menu
    Copy the full SHA
    f83ed71 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Merge remote-tracking branch 'upstream/issue36_coaxialPipes' into iss…

    …ue36_CoaxialPipes
    j_c_cook committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ab572c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Move Gneilinski Nusselt number to a function, remove sharp jumps in c…

    …onvective heat transfer coefficient for circular pipe by interpolation
    j-c-cook committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    9022abc View commit details
    Browse the repository at this point in the history
  2. convective function should only return h_fluid

    j-c-cook committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    a0a049b View commit details
    Browse the repository at this point in the history
  3. Catch the Re=4000 case

    j-c-cook committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    0e1dcd9 View commit details
    Browse the repository at this point in the history
  4. update to documentation, linear interpolation now comes from Gnielins…

    …ki (2013)
    j-c-cook committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    843dd7e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. gnielinski (1975) was not applicable 2300 < Re < 3000, correct docume…

    …ntation
    j-c-cook committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    9dc7e2d View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    4dec949 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Reformat changes to follow PEP8

    j_c_cook committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    974489d View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. Merge branch 'master' into issue36_CoaxialPipes

    j_c_cook committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    f3b576c View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2021

  1. Add second borehole thermal resistance function

    It is not yet clear if this second borehole thermal resistance function
    will be necessary. I will not know until I have completed this and
    Massimo reviews it to see if he could use his own techniques to make it
    happen.
    
    I plan to make use of this function to calculate the effective borehole
    thermal resistance for a concentric (coaxial) pipe arrangement.
    j_c_cook committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    e7e3a0e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into issue36_CoaxialPipes

    Jack Cook authored Apr 11, 2021
    Configuration menu
    Copy the full SHA
    e7b8f4f View commit details
    Browse the repository at this point in the history
  3. Add function to quickly compute coaxial resistance

    A new file has been included with an example. The file is included for
    reviewal purposes by Cimmino.
    j-c-cook committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    85b8330 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Fix coaxial effective borehole resistance

    The calculation has now been checked versus GLHEPRO, two errors were
    found:
    
    - The Reynolds number (Re) was improperly being calculated inside of the
      annulus, thus leading to improper convection coefficients and the
      resulting resistances inside of the annulus (contains inner and outer)
    
    - The hyperbolic cotangent in the uniform borehole wall temperature
      effective resistance was not returning the proper value. This user
      believed that the function "arctanh" in numpy meant hyperbolic
      cotangent. Apparently, it does not. The solution is 1 divided by the
      "tanh" function.
    j_c_cook committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    0760b91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a2e440 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Add double u-tubes to custom borehole example

    j-c-cook committed May 27, 2021
    Configuration menu
    Copy the full SHA
    1344189 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Modify custom borehole example to use media.Fluid

    j-c-cook committed May 28, 2021
    Configuration menu
    Copy the full SHA
    6b6119c View commit details
    Browse the repository at this point in the history
  2. Fix double u-tube parallel bh resistance m_dot

    j_c_cook committed May 28, 2021
    Configuration menu
    Copy the full SHA
    ba0b7db View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Merge branch 'master' into issue36_CoaxialPipes

    Jack Cook authored Aug 23, 2021
    Configuration menu
    Copy the full SHA
    222ff28 View commit details
    Browse the repository at this point in the history
  2. Add concentric convective heat transfer coefficient

    j-c-cook committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    de49359 View commit details
    Browse the repository at this point in the history
  3. Adding coaxial to custom borehole...

    j-c-cook committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    fe7a9a9 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into issue36_CoaxialPipes

    j-c-cook committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    645c743 View commit details
    Browse the repository at this point in the history
  5. Make Coaxial run

    j-c-cook committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    07bb0d6 View commit details
    Browse the repository at this point in the history
  6. Add coaxial function call

    j-c-cook committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    70b6501 View commit details
    Browse the repository at this point in the history
  7. Fix inner and outer radii array definitions

    j-c-cook committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8224783 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f9b7b32 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Fix _check_geometry() to be Coaxial compatible

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    5a3adaa View commit details
    Browse the repository at this point in the history
  2. Refactor custom borehole example (some)

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    a6a9675 View commit details
    Browse the repository at this point in the history
  3. Add Coaxial debugging code

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    556dd0d View commit details
    Browse the repository at this point in the history
  4. Push up solving

    I'll push this so you can see what I did to find that _Rd[0, 0] value
    to make the methods solve for the same effective borehole resistance.
    
    @MassimoCimmino
    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b4957b3 View commit details
    Browse the repository at this point in the history
  5. Fix check_geometry method for coaxial

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    9f28310 View commit details
    Browse the repository at this point in the history
  6. Modify coaxial coordinate input

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    30b102a View commit details
    Browse the repository at this point in the history
  7. Make visualize_boreholes compatible with coaxial

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    e76061a View commit details
    Browse the repository at this point in the history
  8. Plot and save coaxial borehole in custom_borehole

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    80d9bf0 View commit details
    Browse the repository at this point in the history
  9. Add double u-tube to custom borehole example

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b22c35e View commit details
    Browse the repository at this point in the history
  10. Document MassimoCimmino#36 in changelog

    j-c-cook committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    ce11d8b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Configuration menu
    Copy the full SHA
    3efbc1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4321b0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1f06cc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f4cc171 View commit details
    Browse the repository at this point in the history
  5. Reword CHANGELOG.md

    MassimoCimmino committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    8a1ffff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d638256 View commit details
    Browse the repository at this point in the history
  7. Reformat convective_heat_transfer_coefficient_concentric_annulus

    These are general formatting changes along with variable name changes to
    align with the rest of the `pipes` module and the
    `convective_heat_transfer_coefficient_circular_pipe` function.
    MassimoCimmino committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    d93ca95 View commit details
    Browse the repository at this point in the history
  8. Refactor custom_borehole.py

    The definition of each pipe type now has its own section in the script.
    The mass flow is prescribed instead of the volume flow rate as is done in
    the other examples. A mistake was corrected in the call to
    `borehole_thermal_resistance()`: the borehole mass flow rate should be
    provided (as opposed to the pipe mass flow rate). Pipes in single and
    double U-tube boreholes are moved closer to the borehole wall and the
    fluid is changed to propylene glycol 20%.
    MassimoCimmino committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    3a70afd View commit details
    Browse the repository at this point in the history
  9. Update documentation

    MassimoCimmino committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    7f2b0c7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    54ce372 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Fix typos

    MassimoCimmino committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a7357dd View commit details
    Browse the repository at this point in the history