-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue36 coaxial pipes #79
Issue36 coaxial pipes #79
Commits on Nov 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f83ed71 - Browse repository at this point
Copy the full SHA f83ed71View commit details
Commits on Mar 16, 2021
-
Merge remote-tracking branch 'upstream/issue36_coaxialPipes' into iss…
…ue36_CoaxialPipes
j_c_cook committedMar 16, 2021 Configuration menu - View commit details
-
Copy full SHA for ab572c5 - Browse repository at this point
Copy the full SHA ab572c5View commit details
Commits on Mar 20, 2021
-
Move Gneilinski Nusselt number to a function, remove sharp jumps in c…
…onvective heat transfer coefficient for circular pipe by interpolation
j-c-cook committedMar 20, 2021 Configuration menu - View commit details
-
Copy full SHA for 9022abc - Browse repository at this point
Copy the full SHA 9022abcView commit details -
convective function should only return h_fluid
j-c-cook committedMar 20, 2021 Configuration menu - View commit details
-
Copy full SHA for a0a049b - Browse repository at this point
Copy the full SHA a0a049bView commit details -
j-c-cook committed
Mar 20, 2021 Configuration menu - View commit details
-
Copy full SHA for 0e1dcd9 - Browse repository at this point
Copy the full SHA 0e1dcd9View commit details -
update to documentation, linear interpolation now comes from Gnielins…
…ki (2013)
j-c-cook committedMar 20, 2021 Configuration menu - View commit details
-
Copy full SHA for 843dd7e - Browse repository at this point
Copy the full SHA 843dd7eView commit details
Commits on Mar 21, 2021
-
gnielinski (1975) was not applicable 2300 < Re < 3000, correct docume…
…ntation
j-c-cook committedMar 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 9dc7e2d - Browse repository at this point
Copy the full SHA 9dc7e2dView commit details
Commits on Apr 6, 2021
-
convection coefficient for annulus region of concentric pipes
j_c_cook committedApr 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 4dec949 - Browse repository at this point
Copy the full SHA 4dec949View commit details
Commits on Apr 7, 2021
-
Reformat changes to follow PEP8
j_c_cook committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 974489d - Browse repository at this point
Copy the full SHA 974489dView commit details
Commits on Apr 10, 2021
-
Merge branch 'master' into issue36_CoaxialPipes
j_c_cook committedApr 10, 2021 Configuration menu - View commit details
-
Copy full SHA for f3b576c - Browse repository at this point
Copy the full SHA f3b576cView commit details
Commits on Apr 11, 2021
-
Add second borehole thermal resistance function
It is not yet clear if this second borehole thermal resistance function will be necessary. I will not know until I have completed this and Massimo reviews it to see if he could use his own techniques to make it happen. I plan to make use of this function to calculate the effective borehole thermal resistance for a concentric (coaxial) pipe arrangement.
j_c_cook committedApr 11, 2021 Configuration menu - View commit details
-
Copy full SHA for e7e3a0e - Browse repository at this point
Copy the full SHA e7e3a0eView commit details -
Merge branch 'master' into issue36_CoaxialPipes
Jack Cook authoredApr 11, 2021 Configuration menu - View commit details
-
Copy full SHA for e7b8f4f - Browse repository at this point
Copy the full SHA e7b8f4fView commit details -
Add function to quickly compute coaxial resistance
A new file has been included with an example. The file is included for reviewal purposes by Cimmino.
j-c-cook committedApr 11, 2021 Configuration menu - View commit details
-
Copy full SHA for 85b8330 - Browse repository at this point
Copy the full SHA 85b8330View commit details
Commits on Apr 16, 2021
-
Fix coaxial effective borehole resistance
The calculation has now been checked versus GLHEPRO, two errors were found: - The Reynolds number (Re) was improperly being calculated inside of the annulus, thus leading to improper convection coefficients and the resulting resistances inside of the annulus (contains inner and outer) - The hyperbolic cotangent in the uniform borehole wall temperature effective resistance was not returning the proper value. This user believed that the function "arctanh" in numpy meant hyperbolic cotangent. Apparently, it does not. The solution is 1 divided by the "tanh" function.
j_c_cook committedApr 16, 2021 Configuration menu - View commit details
-
Copy full SHA for 0760b91 - Browse repository at this point
Copy the full SHA 0760b91View commit details -
Merge remote-tracking branch 'upstream/master' into issue36_CoaxialPipes
j_c_cook committedApr 16, 2021 Configuration menu - View commit details
-
Copy full SHA for 7a2e440 - Browse repository at this point
Copy the full SHA 7a2e440View commit details
Commits on May 27, 2021
-
Add double u-tubes to custom borehole example
j-c-cook committedMay 27, 2021 Configuration menu - View commit details
-
Copy full SHA for 1344189 - Browse repository at this point
Copy the full SHA 1344189View commit details
Commits on May 28, 2021
-
Modify custom borehole example to use media.Fluid
j-c-cook committedMay 28, 2021 Configuration menu - View commit details
-
Copy full SHA for 6b6119c - Browse repository at this point
Copy the full SHA 6b6119cView commit details -
Fix double u-tube parallel bh resistance m_dot
j_c_cook committedMay 28, 2021 Configuration menu - View commit details
-
Copy full SHA for ba0b7db - Browse repository at this point
Copy the full SHA ba0b7dbView commit details
Commits on Aug 23, 2021
-
Merge branch 'master' into issue36_CoaxialPipes
Jack Cook authoredAug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 222ff28 - Browse repository at this point
Copy the full SHA 222ff28View commit details -
Add concentric convective heat transfer coefficient
j-c-cook committedAug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for de49359 - Browse repository at this point
Copy the full SHA de49359View commit details -
Adding coaxial to custom borehole...
j-c-cook committedAug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for fe7a9a9 - Browse repository at this point
Copy the full SHA fe7a9a9View commit details -
Merge branch 'master' into issue36_CoaxialPipes
j-c-cook committedAug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 645c743 - Browse repository at this point
Copy the full SHA 645c743View commit details -
j-c-cook committed
Aug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 07bb0d6 - Browse repository at this point
Copy the full SHA 07bb0d6View commit details -
j-c-cook committed
Aug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 70b6501 - Browse repository at this point
Copy the full SHA 70b6501View commit details -
Fix inner and outer radii array definitions
j-c-cook committedAug 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 8224783 - Browse repository at this point
Copy the full SHA 8224783View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9b7b32 - Browse repository at this point
Copy the full SHA f9b7b32View commit details
Commits on Aug 24, 2021
-
Fix _check_geometry() to be Coaxial compatible
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 5a3adaa - Browse repository at this point
Copy the full SHA 5a3adaaView commit details -
Refactor custom borehole example (some)
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for a6a9675 - Browse repository at this point
Copy the full SHA a6a9675View commit details -
j-c-cook committed
Aug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 556dd0d - Browse repository at this point
Copy the full SHA 556dd0dView commit details -
I'll push this so you can see what I did to find that _Rd[0, 0] value to make the methods solve for the same effective borehole resistance. @MassimoCimmino
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for b4957b3 - Browse repository at this point
Copy the full SHA b4957b3View commit details -
Fix check_geometry method for coaxial
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 9f28310 - Browse repository at this point
Copy the full SHA 9f28310View commit details -
Modify coaxial coordinate input
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 30b102a - Browse repository at this point
Copy the full SHA 30b102aView commit details -
Make visualize_boreholes compatible with coaxial
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for e76061a - Browse repository at this point
Copy the full SHA e76061aView commit details -
Plot and save coaxial borehole in custom_borehole
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 80d9bf0 - Browse repository at this point
Copy the full SHA 80d9bf0View commit details -
Add double u-tube to custom borehole example
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for b22c35e - Browse repository at this point
Copy the full SHA b22c35eView commit details -
Document MassimoCimmino#36 in changelog
j-c-cook committedAug 24, 2021 Configuration menu - View commit details
-
Copy full SHA for ce11d8b - Browse repository at this point
Copy the full SHA ce11d8bView commit details
Commits on Aug 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3efbc1d - Browse repository at this point
Copy the full SHA 3efbc1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4321b0f - Browse repository at this point
Copy the full SHA 4321b0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f06cc - Browse repository at this point
Copy the full SHA c1f06ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4cc171 - Browse repository at this point
Copy the full SHA f4cc171View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a1ffff - Browse repository at this point
Copy the full SHA 8a1ffffView commit details -
Configuration menu - View commit details
-
Copy full SHA for d638256 - Browse repository at this point
Copy the full SHA d638256View commit details -
Reformat
convective_heat_transfer_coefficient_concentric_annulus
These are general formatting changes along with variable name changes to align with the rest of the `pipes` module and the `convective_heat_transfer_coefficient_circular_pipe` function.
Configuration menu - View commit details
-
Copy full SHA for d93ca95 - Browse repository at this point
Copy the full SHA d93ca95View commit details -
The definition of each pipe type now has its own section in the script. The mass flow is prescribed instead of the volume flow rate as is done in the other examples. A mistake was corrected in the call to `borehole_thermal_resistance()`: the borehole mass flow rate should be provided (as opposed to the pipe mass flow rate). Pipes in single and double U-tube boreholes are moved closer to the borehole wall and the fluid is changed to propylene glycol 20%.
Configuration menu - View commit details
-
Copy full SHA for 3a70afd - Browse repository at this point
Copy the full SHA 3a70afdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f2b0c7 - Browse repository at this point
Copy the full SHA 7f2b0c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54ce372 - Browse repository at this point
Copy the full SHA 54ce372View commit details
Commits on Aug 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a7357dd - Browse repository at this point
Copy the full SHA a7357ddView commit details