This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Prevent no change ticket notification spam #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusulf
reviewed
May 15, 2018
| // But only if the ticket has been changed | ||
| if (update && MUtil.equals(msender.getMessage(), message)) | ||
| { | ||
| msg("<b>Please do not spam our ticket system. Someone will be with you shortly."); |
There was a problem hiding this comment.
Is this really the best way to do it? It could be seen as a bit passive-agressive, and it would also make people realise that the message hasn't been forwarded which makes it easier to trick the system by changing it ever so slightly.
Perhaps just act normally towards the player and not send a message to the moderators?
| if (update && MUtil.equals(msender.getMessage(), message)) | ||
| { | ||
| msg("<b>Please do not spam our ticket system. Someone will be with you shortly."); | ||
| return; |
There was a problem hiding this comment.
This is a question of preference, but you could also throw a MassiveException with the message.
There was a problem hiding this comment.
I had originally thrown a massive exception, but then I realized that we don't seem to do that very often in the commands here, so I went with the message to conform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be notifying staff when a player repeats the ticket creation command to update their ticket with the exact same message. This commit corrects the flawed notification behavior.