Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove appcontext which is removed in flask #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jb-leger
Copy link

@jb-leger jb-leger commented Nov 4, 2023

I had the following bug:

File "/tmp/wex/lib/python3.11/site-packages/flask_cas/__init__.py", line 14, in <module>
 from flask import _request_ctx_stack as stack
ImportError: cannot import name '_request_ctx_stack' from 'flask' (/tmp/wex/lib/python3.11/site-packages/flask/__init__.py)

After some investigations: _app_ctx_stack and _request_ctx_stack were removed in flask. See this PR on flask.

In this extension, contexts are not used, these line are here as a copy of the flask extension dev doc. These line didn't have side effect, to the removal of this line is sufficiant to solve the bug.

@tg2648
Copy link

tg2648 commented Mar 25, 2024

Hello @MasterRoshan, could you please take a look at this PR when you get a chance? It would be great to have flask-cas working with Flask 3.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants