Reflector and parallel downloads support #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltejur
reviewed
Nov 7, 2021
| numpkg=$(whiptail --backtitle "${apptitle}" --title "${txtparallelprompt}" --inputbox "" 0 0 "5" 3>&1 1>&2 2>&3) | ||
| if [ "$?" = "0" ]; then | ||
| if [[ "$numpkg" =~ ^[1-9][0-9]*$ ]] ; then | ||
| sed -i "s/.*ParallelDownloads.*/ParallelDownloads = ${numpkg}/" /etc/pacman.conf |
There was a problem hiding this comment.
Works great for me, but I would have also expected that ParallelDownloads is set in the actual system. This probably wasn't added since the command runs before pacstrap, but could something like this work?
Suggested change
| sed -i "s/.*ParallelDownloads.*/ParallelDownloads = ${numpkg}/" /etc/pacman.conf | |
| sed -i "s/.*ParallelDownloads.*/ParallelDownloads = ${numpkg}/" /etc/pacman.conf | |
| mkdir /mnt/etc && cp /etc/pacman.conf /mnt/etc |
Since this seems pretty ugly to me, maybe a second option in the configuration menu after pacstrap would also be a good idea?
There was a problem hiding this comment.
If we just copy the files over, people might have issues with outdated ISO's and stuff, so instead we could just update pacman.conf right after after pacstrap finishes. I think this is better.
|
Good Job, after one year, I merge it :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184 #160 #180
These would significantly increase the speed of downloading packages.
I have also given the option to edit reflector.conf so that people could customize mirror ranking/filtering