Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUGGESTION: --count option for jf flow list and jf job list #110

Open
utf opened this issue Apr 24, 2024 · 4 comments
Open

SUGGESTION: --count option for jf flow list and jf job list #110

utf opened this issue Apr 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@utf
Copy link
Collaborator

utf commented Apr 24, 2024

It can be useful to know how many jobs you have remaining. I'm potentially interested in implementing this if I have some time.

@davidwaroquiers
Copy link
Member

Hi @utf . That could indeed be useful. In the jobcontroller, there is already the count_jobs and count_flows methods (https://github.com/Matgenix/jobflow-remote/blob/develop/src/jobflow_remote/jobs/jobcontroller.py#L2397 and https://github.com/Matgenix/jobflow-remote/blob/develop/src/jobflow_remote/jobs/jobcontroller.py#L2460) to do it so it should not be too complex to add it to the cli. Maybe it could be "jf job count" and "jf flow count" ? instead of "jf job list --count" and "jf flow list --count" ?

@gpetretto gpetretto added the enhancement New feature or request label Apr 24, 2024
@gpetretto gpetretto self-assigned this Apr 24, 2024
@gpetretto
Copy link
Contributor

I think I can quickly add it, it should be quite easy to do. Let me know if you instead prefer using this as a way to start working your way thorugh jobflow-remote's code.

@utf
Copy link
Collaborator Author

utf commented Apr 24, 2024

Thanks for the suggestions. I'd be quite interested to implement it myself as an opportunity to dig further into the code!

@gpetretto gpetretto removed their assignment Apr 24, 2024
@gpetretto
Copy link
Contributor

Great, thanks! Let me know if you need any clarification. I believe that the CLI section is not the most documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants