-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --worker and --query option in CLI #171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #171 +/- ##
===========================================
- Coverage 47.94% 47.86% -0.09%
===========================================
Files 43 43
Lines 5095 5106 +11
Branches 1103 1109 +6
===========================================
+ Hits 2443 2444 +1
- Misses 2395 2402 +7
- Partials 257 260 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few small comments. Maybe @janosh you can also have a look and test to see if it fits your needs ?
thanks a lot @gpetretto for implementing! looks great 👍 maybe worth mentioning the new flags in the dealing with errors docs?
|
Hi @janosh, thanks for the suggestion. I do not fully agree with it though. I feel like that the error section of the documentation should try to stay focused on the different cases that could happen concerning the errors. This would indeed add additional information, but more on a use case of the CLI rather than explaining how the errors are different from one another and which specific command to use. Maybe a new section of the documentation showing the more commonly used options for the CLI could be a better place to mention this? (I would need to leave this for a future PR though) |
sounds good! i think such a page could make extra sense once the coming |
Closes #170 adding the
--worker
and--query
options in the CLI to filter based on worker name and with a custom query.I considered adding the
--query
for filtering on flows as well, but it seems that the current options basically cover the content of the Flow document. However it can be added if it seems useful.