Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faketime package #108

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Add faketime package #108

merged 2 commits into from
Jun 27, 2023

Conversation

yuhaoth
Copy link
Contributor

@yuhaoth yuhaoth commented Jun 14, 2023

This is prepare for checking data_files

That script will run test with faketime

Test jobs on 6d32bea (running just Linux tests, since there are only Docker file updates):

This is prepare for checking data_files

Signed-off-by: Jerry Yu <[email protected]>
@yuhaoth yuhaoth added enhancement New feature or request size-s Estimated task size: small (~2d) priority-medium labels Jun 14, 2023
@yuhaoth
Copy link
Contributor Author

yuhaoth commented Jun 14, 2023

I tried to build docker image local . apt command pass, but it fails at get DS5.

@yuhaoth yuhaoth linked an issue Jun 14, 2023 that may be closed by this pull request
@gilles-peskine-arm
Copy link
Contributor

it fails at get DS5.

We can no longer build the arm-compilers image, until we find a new way to download DS5 automatically. We rely on having the built image cached. We can still extend it, but only after the DS5 download stage (when rebuilding, the system will continue from the intermediate stage it has in cache). But we don't need faketime in that image anyway: we're only using it to do builds, not run tests.

@@ -89,6 +89,8 @@ RUN apt-get update -q && apt-get install -yq \
zlib1g \
# to build Mbed TLS with MBEDTLS_ZILIB_SUPPORT (removed in 3.0)
zlib1g-dev \
# to run tests in specific time.
faketime \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the list in alphabetical order, it helps when looking at what's there.

Signed-off-by: Jerry Yu <[email protected]>
@yuhaoth
Copy link
Contributor Author

yuhaoth commented Jun 16, 2023

We can no longer build the arm-compilers image, until we find a new way to download DS5 automatically. We rely on having the built image cached. We can still extend it, but only after the DS5 download stage (when rebuilding, the system will continue from the intermediate stage it has in cache). But we don't need faketime in that image anyway: we're only using it to do builds, not run tests.

Does that mean I should put it after arm compilers?

@gilles-peskine-arm
Copy link
Contributor

Does that mean I should put it after arm compilers?

No: just don't change the arm-compilers image.

@yuhaoth
Copy link
Contributor Author

yuhaoth commented Jun 19, 2023

Does that mean I should put it after arm compilers?

No: just don't change the arm-compilers image.

Got it

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on code reading. I've started test jobs.

Copy link

@lpy4105 lpy4105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpy4105 lpy4105 added the approved Approved in review. May need additional CI. label Jun 27, 2023
Copy link
Contributor

@bensze01 bensze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bensze01 bensze01 merged commit 5235f0b into Mbed-TLS:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved in review. May need additional CI. enhancement New feature or request priority-high size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add faketime test script
4 participants