Add xxd for data file regenerating tests #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Yu <[email protected]>
gilles-peskine-arm
approved these changes
Jul 10, 2023
| @@ -85,6 +85,8 @@ RUN apt-get update -q && apt-get install -yq \ | |||
| python3-pip \ | |||
| # for Mbed TLS tests | |||
| valgrind \ | |||
| # for data files generating. xxd is provide by vim | |||
There was a problem hiding this comment.
By vim-common, actually, but I don't mind installing vim.
There was a problem hiding this comment.
For 16.04, it is provide by vim.
I did not try other distro :)
There was a problem hiding this comment.
schroot -c xenial -- dpkg -S bin/xxd
vim-common: /usr/bin/xxd
But it doesn't matter.
gilles-peskine-arm
added
needs: ci
needs: review
needs: reviewer
size-xs
bensze01
approved these changes
Jul 10, 2023
bensze01
added
approved
|
Test runs: |
|
Both CIs built the new images successfully - and both runs failed due to unrelated issues (network issues reaching github on the internal side, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxdcommand is used for generating malformed data files. And Mbed-TLS/mbedtls#7866 introduces tests for data files.