Patch/6.5.1-5 #45
Merged
Patch/6.5.1-5 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies before Release.
Before this fix, SAML2 logout not working as idp redirection on logout was done on the same url as login This commit allow to configure a logout url in picketlink-sp.xml, and redirect on it during logout process Resolves meeds-io/meeds-1771 (cherry picked from commit 6fc7d16)
Before this fix, when login out from saml, the request /portal/doling?GLO=true try to flush 3 cookies (JSESSIONID, rememberme, and oauth_rememberme), do setCookie with empty value. This not flush cookie in browser because cookies path is '/' and not '/portal' In addition, there is one more cookie to flush, which currently recreate the user session. This commit use the correct path for the cookies and add the JSESSIONIDSSO cookie which should be flushed. Resolves meeds-io/meeds-1771 (cherry picked from commit aa15664)
|
1 similar comment
|
hbenali
approved these changes
Mar 27, 2024
auto-merge was automatically disabled
March 27, 2024 10:53
Rebase failed
Merged
hbenali
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from PR & PR