Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Integration - Meeds-io/MIPs#57 #20

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

boubaker
Copy link
Member

( Resolves Meeds-io/MIPs#57 )

@boubaker boubaker marked this pull request as ready for review December 30, 2023 16:48
…Ps#57

Prior to this change, the dispatched request to Target Portlet Context doesn't override the Servlet Context Path which may lead to ambigius Security request filters matching (In Spring Context by example). This change will wrap the original HTTP Resquest to override the context path in order to retrieve the target context servlet path instead of '/portal'.

At the same Time, this will fix unit test that was testing on session nullability when a session was already initiated from Root Context. Knowing that the session is shared between contexts, when the context path has been fixed, the session shouldn't be null anymore in called contexts.
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
3 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@boubaker boubaker merged commit cb9a563 into develop Jan 11, 2024
4 of 5 checks passed
@boubaker boubaker deleted the meeds-spring-mip-57 branch January 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring Integration
2 participants