Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear calcDmgPerHitReport once it is added to vPhaseReport #4647

Merged
merged 1 commit into from
Jul 21, 2023
Merged

clear calcDmgPerHitReport once it is added to vPhaseReport #4647

merged 1 commit into from
Jul 21, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

  • clear calcDmgPerHitReport, once it is added to vPhaseReport

image

fixes #3654

HammerGS
HammerGS approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR and seems to work no issues.

@SJuliez SJuliez merged commit 486a8fc into MegaMek:master Jul 21, 2023
@kuronekochomusuke kuronekochomusuke deleted the issue3654 branch July 29, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammerGS HammerGS HammerGS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[49.8 Testing Branch] Bug or RFE? Confusing Infantry/BA damage message.
3 participants
@kuronekochomusuke @HammerGS @SJuliez