safer movement for princess #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleet01
approved these changes
Sep 11, 2023
NickAragua
reviewed
Sep 12, 2023
| @@ -1239,8 +1239,8 @@ protected MovePath continueMovementFor(final Entity entity) { | |||
|
|
|||
| final long startTime = System.currentTimeMillis(); | |||
| getPathRanker(entity).initUnitTurn(entity, getGame()); | |||
| final double fallTolerance = | |||
| getBehaviorSettings().getFallShameIndex() / 10d; | |||
| // fall tolerance range between 0.50 and 1.0 | |||
There was a problem hiding this comment.
One of the problems with the path ranking algorithm is that it doesn't normalize the "how much damage can I possibly take from enemy fire" evaluation and the "how much damage can I take from falling" evaluation. The latter is always going to be considerably lower, because you only fall over once during a move, but get shot at by many things. This is an ok stopgap for smaller matches, but will have little effect during larger fights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust fall tolerance range to 0.50 and 1.0 instead of 0.0 to 1.0 for PSRs.
Behavior -> Highway Menace ---- Never takes a risk.
when calculating fallback paths use lower of getRunMPwithoutMASC and getRunMP(MPCalculationSetting.NO_GRAVITY)
so that when there is low gravity fewer extended moves will be used.
these should lower the chance for having excessive PSR movement failures when there is low gravity.
fixes #2698