Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Mek crit table improvements #1646

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

@pavelbraginskiy pavelbraginskiy commented Oct 28, 2024

Includes three related features. I implemented the latter two while failing to implement the first one.

  1. See [RFE] Auto Sort Updates #1644. RISC Super-Cooled Myomer slots are autosorted after other equipment.
  2. Changing the myomer type in the Structure tab now fully removes the previous myomer type right away, instead of leaving parts of it in the unit until something else triggered a full refresh.
  3. Critical slots of fixed-location equipment (RISC SCM, Null-Sig, Partial Wing, etc) can now be moved around within a location if you want to reorder them manually:
    image

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.16%. Comparing base (cb0f45e) to head (48b29e1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1646      +/-   ##
===========================================
- Coverage      2.17%   2.16%   -0.01%     
  Complexity      209     209              
===========================================
  Files           266     266              
  Lines         30801   30840      +39     
  Branches       5266    5276      +10     
===========================================
  Hits            669     669              
- Misses        29975   30014      +39     
  Partials        157     157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eq = getUnit().getEquipment(Integer.parseInt(data));
} else {
fixedEquipment = true;
var parts = Arrays.stream(data.split(":")).mapToInt(Integer::parseInt).toArray();

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let someone comment or fix before merging.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work

@HammerGS HammerGS merged commit 27440fe into MegaMek:master Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants