Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a function to return empty table #200

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Develop a function to return empty table #200

merged 8 commits into from
Sep 24, 2024

Conversation

fukuhiro2023
Copy link
Collaborator

@fukuhiro2023 fukuhiro2023 commented Sep 9, 2024 •
edited
Loading

This PR includes:

  • To return an empty table when data has no population by new function empty_table().
  • To update the logic for event count and summary of duration to avoid an error when data has no observation.
  • To delete the last blank row in a specific AE table when data has no observation.

jeetendersinghc and others added 2 commits September 9, 2024 15:11
@jeetendersinghc
Hi Ben,
71998e5 
I have created snapshot for empty table but I have one comments. Though snapshot test is PASS but the final output is not in compliance with A&R standards for following reason:
1. Title is missing
2. foontote are missing
3. format is not following A& R standard.
I can share one standard report from one of the study for your reference.
Thanks,
Jeetender
@jeetendersinghc
Style code (GHA)
75149d9
LittleBeannie
LittleBeannie approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fukuhiro2023 !

@wangben718 wangben718 merged commit 2ba6994 into main Sep 24, 2024
14 checks passed
@nanxstats nanxstats deleted the develop-function-to-return-empty-table branch September 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleBeannie LittleBeannie LittleBeannie approved these changes

@wangben718 wangben718 wangben718 approved these changes

@nanxstats nanxstats Awaiting requested review from nanxstats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fukuhiro2023 @LittleBeannie @wangben718 @jeetendersinghc