Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure proxy timeouts and payload size #702

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Configure proxy timeouts and payload size #702

merged 8 commits into from
Aug 23, 2023

Conversation

filippomc
Copy link
Collaborator

@filippomc filippomc commented Aug 22, 2023

Closes #701

Implemented solution: added values-based configuration for ingress and gatekeepers

How to test this PR: change values-template.yaml file proxy.timeout.send and check it is reflected in the ingress
spec and gatekeepers configmap.

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@filippomc filippomc changed the title Feature/701 Configure proxy timeouts and payload size Aug 22, 2023
Copy link
Contributor

@zsinnema zsinnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/accounts.md Outdated Show resolved Hide resolved
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in ebrains and it worked 👍

@filippomc filippomc merged commit c35f8c3 into develop Aug 23, 2023
3 checks passed
@filippomc filippomc deleted the feature/701 branch August 23, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure timeouts and payload size limits
4 participants