chore: bump typescript to version 5.6.3 (#97)

Just upgrading to the latest stable TypeScript version. This is also related to this comment: #40 (comment). --------- Co-authored-by: Daniel Rocha <[email protected]>
MetaMask · Nov 15, 2024 · 5b2bff8 · 5b2bff8
1 parent 975bd39
commit 5b2bff8
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 24 deletions.
diff --git a/package.json b/package.json
@@ -70,7 +70,7 @@
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.13",
-    "typescript": "~5.4.5"
+    "typescript": "~5.6.3"
   },
   "packageManager": "[email protected]",
   "engines": {

diff --git a/packages/keyring-api/package.json b/packages/keyring-api/package.json
@@ -71,7 +71,7 @@
     "ts-node": "^10.9.2",
     "tsd": "^0.31.0",
     "typedoc": "^0.25.13",
-    "typescript": "~5.4.5"
+    "typescript": "~5.6.3"
   },
   "peerDependencies": {
     "@metamask/providers": "^18.1.0"

diff --git a/packages/keyring-eth-ledger-bridge/package.json b/packages/keyring-eth-ledger-bridge/package.json
@@ -77,7 +77,7 @@
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.13",
-    "typescript": "~5.4.5"
+    "typescript": "~5.6.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

diff --git a/packages/keyring-eth-ledger-bridge/src/ledger-mobile-bridge.test.ts b/packages/keyring-eth-ledger-bridge/src/ledger-mobile-bridge.test.ts
@@ -5,6 +5,10 @@ import { MetaMaskLedgerHwAppEth } from './ledger-hw-app';
 import { LedgerMobileBridge } from './ledger-mobile-bridge';
 import { LedgerTransportMiddleware } from './ledger-transport-middleware';
 
+type MockDeviceModel = {
+  id: string;
+};
+
 const DEVICE_ID = 'DEVICE_ID';
 
 describe('LedgerMobileBridge', function () {
@@ -25,7 +29,7 @@ describe('LedgerMobileBridge', function () {
   };
 
   const mockTransport = {
-    deviceModel: {} || null,
+    deviceModel: { id: '' } as MockDeviceModel, // `id` will be set by `beforeEach`
     send: jest.fn(),
     close: jest.fn(),
     decorateAppAPIMethods: jest.fn(),
@@ -220,8 +224,8 @@ describe('LedgerMobileBridge', function () {
       );
     });
 
-    it('throws error when transport.deviceMode is not set', async function () {
-      mockTransport.deviceModel = null;
+    it('throws error when transport.deviceModel is not set', async function () {
+      mockTransport.deviceModel = null as unknown as MockDeviceModel;
       await expect(
         bridge.updateTransportMethod(mockTransport as unknown as Transport),
       ).rejects.toThrow(

diff --git a/packages/keyring-eth-simple/package.json b/packages/keyring-eth-simple/package.json
@@ -67,7 +67,7 @@
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.13",
-    "typescript": "~5.4.5"
+    "typescript": "~5.6.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

diff --git a/packages/keyring-eth-trezor/package.json b/packages/keyring-eth-trezor/package.json
@@ -77,7 +77,7 @@
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.13",
-    "typescript": "~5.4.5"
+    "typescript": "~5.6.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

diff --git a/packages/keyring-snap-bridge/package.json b/packages/keyring-snap-bridge/package.json
@@ -59,7 +59,7 @@
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.13",
-    "typescript": "~5.4.5"
+    "typescript": "~5.6.3"
   },
   "peerDependencies": {
     "@metamask/keyring-api": "workspace:^"

diff --git a/packages/keyring-snap-bridge/src/SnapKeyring.test.ts b/packages/keyring-snap-bridge/src/SnapKeyring.test.ts
@@ -394,7 +394,7 @@ describe('SnapKeyring', () => {
 
       it('fails when the EthMethod is not supported after update', async () => {
         // Update first account to remove `EthMethod.PersonalSign`
-        let updatedMethods = Object.values(EthMethod).filter(
+        let updatedMethods: EthMethod[] = Object.values(EthMethod).filter(
           (method) => method !== EthMethod.PersonalSign,
         );
         expect(

diff --git a/yarn.lock b/yarn.lock
@@ -1672,7 +1672,7 @@ __metadata:
     ts-jest: "npm:^29.0.5"
     ts-node: "npm:^10.9.2"
     typedoc: "npm:^0.25.13"
-    typescript: "npm:~5.4.5"
+    typescript: "npm:~5.6.3"
   languageName: unknown
   linkType: soft
 
@@ -1917,7 +1917,7 @@ __metadata:
     ts-jest: "npm:^29.0.5"
     ts-node: "npm:^10.9.2"
     typedoc: "npm:^0.25.13"
-    typescript: "npm:~5.4.5"
+    typescript: "npm:~5.6.3"
   languageName: unknown
   linkType: soft
 
@@ -1983,7 +1983,7 @@ __metadata:
     ts-jest: "npm:^29.0.5"
     ts-node: "npm:^10.9.2"
     typedoc: "npm:^0.25.13"
-    typescript: "npm:~5.4.5"
+    typescript: "npm:~5.6.3"
   languageName: unknown
   linkType: soft
 
@@ -2012,7 +2012,7 @@ __metadata:
     ts-jest: "npm:^29.0.5"
     ts-node: "npm:^10.9.2"
     typedoc: "npm:^0.25.13"
-    typescript: "npm:~5.4.5"
+    typescript: "npm:~5.6.3"
     uuid: "npm:^9.0.1"
   peerDependencies:
     "@metamask/keyring-api": "workspace:^"
@@ -2051,7 +2051,7 @@ __metadata:
     ts-node: "npm:^10.9.2"
     tslib: "npm:^2.6.2"
     typedoc: "npm:^0.25.13"
-    typescript: "npm:~5.4.5"
+    typescript: "npm:~5.6.3"
   languageName: unknown
   linkType: soft
 
@@ -2139,7 +2139,7 @@ __metadata:
     ts-node: "npm:^10.9.2"
     tsd: "npm:^0.31.0"
     typedoc: "npm:^0.25.13"
-    typescript: "npm:~5.4.5"
+    typescript: "npm:~5.6.3"
     uuid: "npm:^9.0.1"
     webextension-polyfill: "npm:^0.12.0"
   peerDependencies:
@@ -11200,23 +11200,23 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@npm:~5.4.5":
-  version: 5.4.5
-  resolution: "typescript@npm:5.4.5"
+"typescript@npm:~5.6.3":
+  version: 5.6.3
+  resolution: "typescript@npm:5.6.3"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10/d04a9e27e6d83861f2126665aa8d84847e8ebabcea9125b9ebc30370b98cb38b5dff2508d74e2326a744938191a83a69aa9fddab41f193ffa43eabfdf3f190a5
+  checksum: 10/c328e418e124b500908781d9f7b9b93cf08b66bf5936d94332b463822eea2f4e62973bfb3b8a745fdc038785cb66cf59d1092bac3ec2ac6a3e5854687f7833f1
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@npm%3A~5.4.5#optional!builtin<compat/typescript>":
-  version: 5.4.5
-  resolution: "typescript@patch:typescript@npm%3A5.4.5#optional!builtin<compat/typescript>::version=5.4.5&hash=5adc0c"
+"typescript@patch:typescript@npm%3A~5.6.3#optional!builtin<compat/typescript>":
+  version: 5.6.3
+  resolution: "typescript@patch:typescript@npm%3A5.6.3#optional!builtin<compat/typescript>::version=5.6.3&hash=8c6c40"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10/760f7d92fb383dbf7dee2443bf902f4365db2117f96f875cf809167f6103d55064de973db9f78fe8f31ec08fff52b2c969aee0d310939c0a3798ec75d0bca2e1
+  checksum: 10/00504c01ee42d470c23495426af07512e25e6546bce7e24572e72a9ca2e6b2e9bea63de4286c3cfea644874da1467dcfca23f4f98f7caf20f8b03c0213bb6837
   languageName: node
   linkType: hard