Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add new package @metamask/keyring-utils #22

Closed
wants to merge 6 commits into from

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Sep 6, 2024

Requires

Description

This is the first split of the keyring-api. Most utils now goes into the new package keyring-utils.

@ccharly ccharly marked this pull request as ready for review September 6, 2024 16:14
@ccharly ccharly requested a review from a team as a code owner September 6, 2024 16:14
@ccharly ccharly changed the title refactor: add new package @metamask/keyring-utils refactor: add new package @metamask/keyring-utils Sep 6, 2024
@ccharly ccharly changed the title refactor: add new package @metamask/keyring-utils refactor: add new package @metamask/keyring-utils Sep 6, 2024
@ccharly
Copy link
Collaborator Author

ccharly commented Sep 6, 2024

@metamaskbot publish-preview

1 similar comment
@ccharly
Copy link
Collaborator Author

ccharly commented Sep 9, 2024

@metamaskbot publish-preview

Copy link

github-actions bot commented Sep 9, 2024

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "8.1.0-preview-e65b905",
  "@metamask-previews/eth-hd-keyring": "7.0.1-preview-e65b905",
  "@metamask-previews/eth-ledger-bridge-keyring": "4.1.1-preview-e65b905",
  "@metamask-previews/eth-simple-keyring": "6.0.2-preview-e65b905",
  "@metamask-previews/eth-trezor-keyring": "3.1.0-preview-e65b905",
  "@metamask-previews/eth-snap-keyring": "4.3.2-preview-e65b905",
  "@metamask-previews/keyring-utils": "0.0.1-preview-e65b905"
}

@ccharly
Copy link
Collaborator Author

ccharly commented Sep 9, 2024

@metamaskbot publish-preview

Copy link

github-actions bot commented Sep 9, 2024

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "8.1.0-preview-46bb5ff",
  "@metamask-previews/eth-hd-keyring": "7.0.1-preview-46bb5ff",
  "@metamask-previews/eth-ledger-bridge-keyring": "4.1.1-preview-46bb5ff",
  "@metamask-previews/eth-simple-keyring": "6.0.2-preview-46bb5ff",
  "@metamask-previews/eth-trezor-keyring": "3.1.0-preview-46bb5ff",
  "@metamask-previews/eth-snap-keyring": "4.3.2-preview-46bb5ff",
  "@metamask-previews/keyring-utils": "0.0.1-preview-46bb5ff"
}

@ccharly
Copy link
Collaborator Author

ccharly commented Sep 13, 2024

Closing in favor of:

@ccharly ccharly closed this Sep 13, 2024
@ccharly ccharly deleted the refactor/keyring-utils branch September 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant