Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump typescript to version 5.6.3 #97

Merged
merged 5 commits into from
Nov 15, 2024
Merged

chore: bump typescript to version 5.6.3 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c459d37
chore: bump typescript to version 5.6.3
ccharly Nov 15, 2024
3fbff4c
test: fix typing issue
ccharly Nov 15, 2024
ac2b560
refactor: use @ts-ignore instead of type cast
ccharly Nov 15, 2024
cdb4e87
chore: better comment
ccharly Nov 15, 2024
0f6db0e
refactor: @ts-ignore -> @ts-expect-error
ccharly Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"ts-jest": "^29.0.5",
"ts-node": "^10.9.2",
"typedoc": "^0.25.13",
"typescript": "~5.4.5"
"typescript": "~5.6.3"
},
"packageManager": "[email protected]",
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"ts-node": "^10.9.2",
"tsd": "^0.31.0",
"typedoc": "^0.25.13",
"typescript": "~5.4.5"
"typescript": "~5.6.3"
},
"peerDependencies": {
"@metamask/providers": "^18.1.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-ledger-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"ts-jest": "^29.0.5",
"ts-node": "^10.9.2",
"typedoc": "^0.25.13",
"typescript": "~5.4.5"
"typescript": "~5.6.3"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
9 changes: 7 additions & 2 deletions packages/keyring-eth-ledger-bridge/src/ledger-mobile-bridge.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ import { MetaMaskLedgerHwAppEth } from './ledger-hw-app';
import { LedgerMobileBridge } from './ledger-mobile-bridge';
import { LedgerTransportMiddleware } from './ledger-transport-middleware';

type MockDeviceModel = {
id: string;
};

const DEVICE_ID = 'DEVICE_ID';

describe('LedgerMobileBridge', function () {
Expand All @@ -25,7 +29,7 @@ describe('LedgerMobileBridge', function () {
};

const mockTransport = {
deviceModel: {} || null,
deviceModel: { id: '' } as MockDeviceModel, // `id` will be set by `beforeEach`
send: jest.fn(),
close: jest.fn(),
decorateAppAPIMethods: jest.fn(),
Expand Down Expand Up @@ -220,7 +224,8 @@ describe('LedgerMobileBridge', function () {
);
});

it('throws error when transport.deviceMode is not set', async function () {
it('throws error when transport.deviceModel is not set', async function () {
// @ts-expect-error `deviceModel` must be null to validate this test case
mockTransport.deviceModel = null;
await expect(
bridge.updateTransportMethod(mockTransport as unknown as Transport),
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-simple/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"ts-jest": "^29.0.5",
"ts-node": "^10.9.2",
"typedoc": "^0.25.13",
"typescript": "~5.4.5"
"typescript": "~5.6.3"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-eth-trezor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"ts-jest": "^29.0.5",
"ts-node": "^10.9.2",
"typedoc": "^0.25.13",
"typescript": "~5.4.5"
"typescript": "~5.6.3"
},
"engines": {
"node": "^18.18 || >=20"
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-snap-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"ts-jest": "^29.0.5",
"ts-node": "^10.9.2",
"typedoc": "^0.25.13",
"typescript": "~5.4.5"
"typescript": "~5.6.3"
},
"peerDependencies": {
"@metamask/keyring-api": "workspace:^"
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-snap-bridge/src/SnapKeyring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ describe('SnapKeyring', () => {

it('fails when the EthMethod is not supported after update', async () => {
// Update first account to remove `EthMethod.PersonalSign`
let updatedMethods = Object.values(EthMethod).filter(
let updatedMethods: EthMethod[] = Object.values(EthMethod).filter(
(method) => method !== EthMethod.PersonalSign,
);
expect(
Expand Down
28 changes: 14 additions & 14 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,7 +1672,7 @@ __metadata:
ts-jest: "npm:^29.0.5"
ts-node: "npm:^10.9.2"
typedoc: "npm:^0.25.13"
typescript: "npm:~5.4.5"
typescript: "npm:~5.6.3"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -1917,7 +1917,7 @@ __metadata:
ts-jest: "npm:^29.0.5"
ts-node: "npm:^10.9.2"
typedoc: "npm:^0.25.13"
typescript: "npm:~5.4.5"
typescript: "npm:~5.6.3"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -1983,7 +1983,7 @@ __metadata:
ts-jest: "npm:^29.0.5"
ts-node: "npm:^10.9.2"
typedoc: "npm:^0.25.13"
typescript: "npm:~5.4.5"
typescript: "npm:~5.6.3"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -2012,7 +2012,7 @@ __metadata:
ts-jest: "npm:^29.0.5"
ts-node: "npm:^10.9.2"
typedoc: "npm:^0.25.13"
typescript: "npm:~5.4.5"
typescript: "npm:~5.6.3"
uuid: "npm:^9.0.1"
peerDependencies:
"@metamask/keyring-api": "workspace:^"
Expand Down Expand Up @@ -2051,7 +2051,7 @@ __metadata:
ts-node: "npm:^10.9.2"
tslib: "npm:^2.6.2"
typedoc: "npm:^0.25.13"
typescript: "npm:~5.4.5"
typescript: "npm:~5.6.3"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -2139,7 +2139,7 @@ __metadata:
ts-node: "npm:^10.9.2"
tsd: "npm:^0.31.0"
typedoc: "npm:^0.25.13"
typescript: "npm:~5.4.5"
typescript: "npm:~5.6.3"
uuid: "npm:^9.0.1"
webextension-polyfill: "npm:^0.12.0"
peerDependencies:
Expand Down Expand Up @@ -11200,23 +11200,23 @@ __metadata:
languageName: node
linkType: hard

"typescript@npm:~5.4.5":
version: 5.4.5
resolution: "typescript@npm:5.4.5"
"typescript@npm:~5.6.3":
version: 5.6.3
resolution: "typescript@npm:5.6.3"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
checksum: 10/d04a9e27e6d83861f2126665aa8d84847e8ebabcea9125b9ebc30370b98cb38b5dff2508d74e2326a744938191a83a69aa9fddab41f193ffa43eabfdf3f190a5
checksum: 10/c328e418e124b500908781d9f7b9b93cf08b66bf5936d94332b463822eea2f4e62973bfb3b8a745fdc038785cb66cf59d1092bac3ec2ac6a3e5854687f7833f1
languageName: node
linkType: hard

"typescript@patch:typescript@npm%3A~5.4.5#optional!builtin<compat/typescript>":
version: 5.4.5
resolution: "typescript@patch:typescript@npm%3A5.4.5#optional!builtin<compat/typescript>::version=5.4.5&hash=5adc0c"
"typescript@patch:typescript@npm%3A~5.6.3#optional!builtin<compat/typescript>":
version: 5.6.3
resolution: "typescript@patch:typescript@npm%3A5.6.3#optional!builtin<compat/typescript>::version=5.6.3&hash=8c6c40"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
checksum: 10/760f7d92fb383dbf7dee2443bf902f4365db2117f96f875cf809167f6103d55064de973db9f78fe8f31ec08fff52b2c969aee0d310939c0a3798ec75d0bca2e1
checksum: 10/00504c01ee42d470c23495426af07512e25e6546bce7e24572e72a9ca2e6b2e9bea63de4286c3cfea644874da1467dcfca23f4f98f7caf20f8b03c0213bb6837
languageName: node
linkType: hard

Expand Down