Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend testing guidelines #38

Merged
merged 28 commits into from
Sep 1, 2023
Merged

Extend testing guidelines #38

merged 28 commits into from
Sep 1, 2023

Commits on Aug 15, 2023

  1. Extend testing guidelines 

    This PR proposes a new set of guidelines for writing unit tests across
our projects. Most are new, or if they are followed to some degree, they
have not yet been codified.
    @mcmire
    mcmire committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7015953 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge branch 'main' into add-more-testing-guidelines

    @mcmire
    mcmire committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1943265 View commit details
    Browse the repository at this point in the history

  2. Reword guideline around phases

    @mcmire
    mcmire committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7b23c47 View commit details
    Browse the repository at this point in the history

  3. Remove point about sandboxing

    @mcmire
    mcmire committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    18feed3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Revert these changes right now

    @mcmire
    mcmire committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a5803ab View commit details
    Browse the repository at this point in the history

  2. Revise 'Keep tests isolated' section 

    - Remove arguments for non-determinism
- Make sub-guidelines more concise and hide details
    @mcmire
    mcmire committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    45403ef View commit details
    Browse the repository at this point in the history

  3. Revise wording for 'Reset shared variables'

    @mcmire
    mcmire committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    48d3c7a View commit details
    Browse the repository at this point in the history

  4. Be more concise in hooks guideline

    @mcmire
    mcmire committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    054f0c4 View commit details
    Browse the repository at this point in the history

  5. Hooks guideline: reword sentence

    @mcmire
    mcmire committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    079c957 View commit details
    Browse the repository at this point in the history

  6. Use finally instead of catch

    @mcmire
    mcmire committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    93daeb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Remove needless phrase

    @mcmire
    mcmire committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d816589 View commit details
    Browse the repository at this point in the history

  2. Fix example for testing private code guideline

    @mcmire
    mcmire committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6646934 View commit details
    Browse the repository at this point in the history

  3. WIP

    @mcmire
    mcmire committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bbcb175 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Update guideline that talks about behavior

    @mcmire
    mcmire committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    9f89251 View commit details
    Browse the repository at this point in the history

  2. Don't use 'a promise that resolves to...'

    @mcmire
    mcmire committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2e1a567 View commit details
    Browse the repository at this point in the history

  3. Tweak 'test isolation' guideline

    @mcmire
    mcmire committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    dcb3e71 View commit details
    Browse the repository at this point in the history

  4. Tweak 'hooks' guideline

    @mcmire
    mcmire committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    7a34dfe View commit details
    Browse the repository at this point in the history

  5. Revise section on hooks (-> 'beforeEach')

    @mcmire
    mcmire committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    1a8381b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Merge branch 'main' into add-more-testing-guidelines

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    24442e9 View commit details
    Browse the repository at this point in the history

  2. Lint unit-testing doc

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    9a9d64d View commit details
    Browse the repository at this point in the history

  3. Tweak guideline for 'it describes behavior'

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    ac4e93e View commit details
    Browse the repository at this point in the history

  4. Tweak 'it' guideline again

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    690d04a View commit details
    Browse the repository at this point in the history

  5. Tweak 'keep tests focused' guideline

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    4451d60 View commit details
    Browse the repository at this point in the history

  6. Make the example in 'Keep critical data in the test' better

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    09116f7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into add-more-testing-guidelines

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    e346c7f View commit details
    Browse the repository at this point in the history

  8. Tweak 'use describe for scenarios' guideline

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    1decf7b View commit details
    Browse the repository at this point in the history

  9. Remove guideline on grouping tests by file

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    34f61b6 View commit details
    Browse the repository at this point in the history

  10. Tweak guideline on grouping tests by function/method

    @mcmire
    mcmire committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c35dd02 View commit details
    Browse the repository at this point in the history