Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations guidelines #96

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

migrations guidelines #96

wants to merge 17 commits into from

Conversation

tommasini
Copy link

No description provided.

@tommasini tommasini requested a review from a team as a code owner June 18, 2024 13:16
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, here are some individual suggestions (one for each section) to improve the format (not changing the meaning at all):

  • formatting (mostly making it bullet point lists)
  • reverting the sentences by putting the action the dev has to do first then how and why doing it.

docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…d only with important notes for the migration process in general
…what state integrety checks section was saying
@tommasini
Copy link
Author

Hey @Gudahtt Thanks for the review!!
I resolved all your comments because I re-wrote these guidelines in a more general and less verbose way, I think it went in the direction of your review comments! Let me know your thoughts

Copy link

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few syntax issues

docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
docs/migrations-guidelines.md Outdated Show resolved Hide resolved
Cal-L
Cal-L previously approved these changes Jul 11, 2024
Copy link

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NicolasMassart
NicolasMassart previously approved these changes Jul 24, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gambinish
Copy link

Apologies if this is already a thing, but is there a way to export state logs in the mobile app?

In Extension, you can do this in Settings > Advanced

- Always return the state at the end of the migration function, whether it was modified or not,
- Returning the state ensures that the migration process completes and the state is passed to the next migrations.

## Testing Guidelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something to look at the oldest widely adopted version to generate the first set of state for testing?

@sethkfman
Copy link
Contributor

Apologies if this is already a thing, but is there a way to export state logs in the mobile app?

In Extension, you can do this in Settings > Advanced

@gambinish
Screenshot 2024-11-15 at 10 50 39

Copy link

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants