-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrations guidelines #96
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, here are some individual suggestions (one for each section) to improve the format (not changing the meaning at all):
- formatting (mostly making it bullet point lists)
- reverting the sentences by putting the action the dev has to do first then how and why doing it.
…uidelines md file
…d only with important notes for the migration process in general
…what state integrety checks section was saying
Hey @Gudahtt Thanks for the review!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a few syntax issues
Co-authored-by: Cal Leung <[email protected]>
Co-authored-by: Cal Leung <[email protected]>
Co-authored-by: Cal Leung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Apologies if this is already a thing, but is there a way to export state logs in the mobile app? In Extension, you can do this in |
- Always return the state at the end of the migration function, whether it was modified or not, | ||
- Returning the state ensures that the migration process completes and the state is passed to the next migrations. | ||
|
||
## Testing Guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add something to look at the oldest widely adopted version to generate the first set of state for testing?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.