Remove warning in NetworkController unit tests (#1300)

In the NetworkController unit tests we use `setTimeout` to wait for
events to occur. We also use `clearTimeout` in the same context to stop
waiting if need be. Because we use fake timers in these tests we need
the original versions of these functions and not the fake versions. We
already capture the original version of `setTimeout` up front, but we
don't do the same for `clearTimeout`, and that leads to a warning being
printed when we use it. This commit captures `clearTimeout` up front as
well to prevent this warning.

Co-authored-by: Mark Stacey <[email protected]>

packages/network-controller/tests/NetworkController.test.ts

@@ -49,8 +49,9 @@ jest.mock('uuid', () => {
   };
 });
 
-// Store this up front so it doesn't get lost when it is stubbed
+// Store these up front so we can use them even when faking timers
 const originalSetTimeout = global.setTimeout;
+const originalClearTimeout = global.clearTimeout;
 
 const createNetworkClientMock = jest.mocked(createNetworkClient);
 
@@ -7510,7 +7511,7 @@ async function waitForPublishedEvents<E extends NetworkControllerEvents>(
        */
       function stopTimer() {
         if (timer) {
-          clearTimeout(timer);
+          originalClearTimeout(timer);
         }
       }