Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkController: Use the same middleware stack as the extension #1116

Merged
merged 87 commits into from
May 3, 2023
Merged

NetworkController: Use the same middleware stack as the extension #1116

merged 87 commits into from
May 3, 2023

Commits on Apr 18, 2023

  1. Added network clients

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c33d89c View commit details
    Browse the repository at this point in the history

  2. Implement PR feedback

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    8189e3a View commit details
    Browse the repository at this point in the history

  3. Fix linting issues

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    48cad87 View commit details
    Browse the repository at this point in the history

  4. Change chainId hex conversion to use controller utils

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f213f24 View commit details
    Browse the repository at this point in the history

  5. Remove dist from imports

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    a3ad5d1 View commit details
    Browse the repository at this point in the history

  6. Change InfuraNetworkType to exclude keys from NetworkType

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    87a2323 View commit details
    Browse the repository at this point in the history

  7. Remove throwing when using setProviderType, throws inside of configur… 

    …eProvider instead now
    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ab385f0 View commit details
    Browse the repository at this point in the history

  8. Fix typing issue after changing InfuraNetworkType

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    1e83353 View commit details
    Browse the repository at this point in the history

  9. lint fix

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    cb17fbe View commit details
    Browse the repository at this point in the history

  10. Remove old networkclient test files

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    9acf3bb View commit details
    Browse the repository at this point in the history

  11. fix more rebase issues

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d5dacd5 View commit details
    Browse the repository at this point in the history

  12. Added PR feedback

    @BelfordZ @Gudahtt
    BelfordZ authored and Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c115bb2 View commit details
    Browse the repository at this point in the history

  13. Undo unnecessary change

    @Gudahtt
    Gudahtt committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    1de386f View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Extract FakeBlockTracker to separate file; improve stub

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    95f152c View commit details
    Browse the repository at this point in the history

  2. Rename fake-provider-engine to match class; simplify impl

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3835661 View commit details
    Browse the repository at this point in the history

  3. No need to account for provider errors

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a759057 View commit details
    Browse the repository at this point in the history

  4. No need to 'stop' the provider anymore

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d48f257 View commit details
    Browse the repository at this point in the history

  5. Make InfuraNetworkType a 'real' enum

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    998a611 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    85735b3 View commit details
    Browse the repository at this point in the history

  7. Extract INFURA_NETWORKS to match the extension

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    507710d View commit details
    Browse the repository at this point in the history

  8. Don't make the reader do hex conversion in their head

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    76643a8 View commit details
    Browse the repository at this point in the history

  9. Document this new behavior

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    92040ea View commit details
    Browse the repository at this point in the history

  10. No need to mock eth-json-rpc-middleware and eth-json-rpc-provider

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2322306 View commit details
    Browse the repository at this point in the history

  11. Fix failing test resulting from merge conflicts

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f12a65e View commit details
    Browse the repository at this point in the history

  12. Fix formatting

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1fd7246 View commit details
    Browse the repository at this point in the history

  13. Tweak these error messages

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    30ca47f View commit details
    Browse the repository at this point in the history

  14. Tweak these names to match the objects they represent

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3d1ec25 View commit details
    Browse the repository at this point in the history

  15. Get most of the network client test files matching extension (except … 

    …for shared-tests)
    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    be564e7 View commit details
    Browse the repository at this point in the history

  16. Match shared-tests to the extension

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    683d77f View commit details
    Browse the repository at this point in the history

  17. Fix lint issues

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    dcc0d47 View commit details
    Browse the repository at this point in the history

  18. Match the extension better in the unit tests

    @mcmire
    mcmire committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ccb87a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    76145b8 View commit details
    Browse the repository at this point in the history

  2. Fix TypeScript issues

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f702ba3 View commit details
    Browse the repository at this point in the history

  3. We can give Provider and BlockTracker proper types now

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    41a5182 View commit details
    Browse the repository at this point in the history

  4. Rename buildFakeClient to buildFakeNetworkClient, have its provider b… 

    …e required
    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ef644f0 View commit details
    Browse the repository at this point in the history

  5. Fix all cases of using 0x-prefix hex strings when it would throw an e… 

    …rror
    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4650a6d View commit details
    Browse the repository at this point in the history

  6. These arguments always get passed

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2c46e85 View commit details
    Browse the repository at this point in the history

  7. Throw if infuraProjectId is not set

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    306bf54 View commit details
    Browse the repository at this point in the history

  8. Revert these changes as they are unnecessary for now

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fd14151 View commit details
    Browse the repository at this point in the history

  9. Fix failing tests

    @mcmire
    mcmire committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8bc6de5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. Use 'any' for TransactionController provider and blockTracker

    @mcmire
    mcmire committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    009e854 View commit details
    Browse the repository at this point in the history

  2. Add missing tests

    @mcmire
    mcmire committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    366138c View commit details
    Browse the repository at this point in the history

  3. Change this back to make test copying easier

    @mcmire
    mcmire committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    b7731fe View commit details
    Browse the repository at this point in the history

  4. Revert "We can give Provider and BlockTracker proper types now" 

    This reverts commit 41a5182. We can do
this in another commit.
    @mcmire
    mcmire committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ae08915 View commit details
    Browse the repository at this point in the history

  5. Revert "Use 'any' for TransactionController provider and blockTracker" 

    This reverts commit 009e854. We can do
this in another commit.
    @mcmire
    mcmire committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    7afc2d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @legobeat
    legobeat authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6c76aa4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into added-network-clients-rebased

    @legobeat
    legobeat authored Apr 26, 2023
    Configuration menu
    Copy the full SHA
    61a255b View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    61f8b9c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5fae751 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary ESLint config file

    @mcmire
    mcmire committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    02087e6 View commit details
    Browse the repository at this point in the history

  4. Don't need this ESLint override anymore

    @mcmire
    mcmire committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c3e0b7a View commit details
    Browse the repository at this point in the history

  5. Fix build failure

    @mcmire
    mcmire committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6c0da5e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d06f8e4 View commit details
    Browse the repository at this point in the history

  2. Align closer to refactor-network-client branch

    @mcmire
    mcmire committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    7a27505 View commit details
    Browse the repository at this point in the history

  3. Fix TransactionController tests

    @mcmire
    mcmire committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    b5f3b0f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    cf9ae84 View commit details
    Browse the repository at this point in the history

  2. Fix lint issue

    @mcmire
    mcmire committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    398b1ce View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 1, 2023
    Configuration menu
    Copy the full SHA
    35b35f1 View commit details
    Browse the repository at this point in the history

  2. Fixes

    @mcmire
    mcmire committed May 1, 2023
    Configuration menu
    Copy the full SHA
    de93343 View commit details
    Browse the repository at this point in the history

  3. More fixes

    @mcmire
    mcmire committed May 1, 2023
    Configuration menu
    Copy the full SHA
    013ec7a View commit details
    Browse the repository at this point in the history

  4. Fix failing test

    @mcmire
    mcmire committed May 1, 2023
    Configuration menu
    Copy the full SHA
    2963d14 View commit details
    Browse the repository at this point in the history

  5. Fix failing test

    @mcmire
    mcmire committed May 1, 2023
    Configuration menu
    Copy the full SHA
    e1c7795 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ced37b0 View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    53347ef View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    133b5fd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6d0d6f6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    14eec34 View commit details
    Browse the repository at this point in the history

  6. I guess we don't need this change right now, we can always add this l… 

    …ater
    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f660310 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3d24650 View commit details
    Browse the repository at this point in the history

  8. Bump eth-block-tracker to 7.0.1

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c3b2849 View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    893d5ae View commit details
    Browse the repository at this point in the history

  10. Roll these particular changes back

    @mcmire
    mcmire committed May 2, 2023
    Configuration menu
    Copy the full SHA
    267eab4 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Merge remote-tracking branch 'origin/main' into added-network-clients… 

    …-rebased

* origin/main:
  docs: update controller-utils/isValidHexAddress to match reality (#1308)
  keyring-controller: validate from-address in signTypedMessage (#1293)
  NetworkController: Fix chain IDs in tests (#1307)
  NetworkController: Normalize INFURA_NETWORKS array (#1306)
    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    32736e8 View commit details
    Browse the repository at this point in the history

  2. Fix lint error

    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e5940ee View commit details
    Browse the repository at this point in the history

  3. Fix test

    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2fb0d47 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary lint rule

    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    81cbd16 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary test changes

    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    956110a View commit details
    Browse the repository at this point in the history

  6. Use unknown instead of any for fake provider params

    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4a2888d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8f6251a View commit details
    Browse the repository at this point in the history

  8. Fix failing AssetsContractController test

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3281087 View commit details
    Browse the repository at this point in the history

  9. Oh, actually, we don't need these changes

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    49dd75a View commit details
    Browse the repository at this point in the history

  10. We can test eth_subscribe and eth_unsubscribe now

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    12a73d5 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into added-network-clients-rebased

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    322f457 View commit details
    Browse the repository at this point in the history

  12. Drop these minor changes as well

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    643b0fa View commit details
    Browse the repository at this point in the history

  13. Make this chain ID more clear

    @mcmire
    mcmire committed May 3, 2023
    Configuration menu
    Copy the full SHA
    39331ca View commit details
    Browse the repository at this point in the history

  14. Update packages/network-controller/tests/NetworkController.test.ts 

    Co-authored-by: Mark Stacey <[email protected]>
    @mcmire @Gudahtt
    mcmire and Gudahtt authored May 3, 2023
    Configuration menu
    Copy the full SHA
    9a23693 View commit details
    Browse the repository at this point in the history

  15. Merge remote-tracking branch 'origin/main' into added-network-clients… 

    …-rebased

* origin/main:
  Simplify the `setFakeProvider` test helper (#1317)
    @Gudahtt
    Gudahtt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    78e3bd0 View commit details
    Browse the repository at this point in the history