deps: Bump `@metamask/{eth-json-rpc-provider,rpc-errors}` #1653

legobeat · 2023-09-01T23:33:14Z

Explanation

Combination of:

References

Blocked by

Blocking

deps: Update @metamask/utils and @metamask/rpc-errors snaps#1728

socket-security · 2023-09-01T23:35:30Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/eth-json-rpc-middleware	12.0.0	None	`+8`	401 kB	metamaskbot
@metamask/eth-json-rpc-provider	2.2.0	None	`+0`	24.2 kB	metamaskbot
@metamask/eth-json-rpc-infura	9.0.0	None	`+2`	92.9 kB	gudahtt
eth-block-tracker	8.0.0	None	`+4`	130 kB	gudahtt

socket-security · 2023-09-08T10:00:33Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

legobeat · 2023-09-08T10:25:26Z

@SocketSecurity ignore [email protected]

new author ok (known version)

legobeat · 2023-09-10T02:50:11Z

@SocketSecurity ignore [email protected]

unstable ownership ok

…^12.0.0

…PollingBlockTracker to type BlockTracker

This reverts commit bc269f5.

Co-authored-by: Elliot Winkler <[email protected]>

mcmire

Looks great! Merge away 💪🏻

mcmire · 2023-10-11T17:29:12Z

tests/fake-block-tracker.ts

@@ -13,10 +13,9 @@ export class FakeBlockTracker extends PollingBlockTracker {
    super({
      provider: new SafeEventEmitterProvider({ engine: new JsonRpcEngine() }),
    });
-  }
-
-  override async _start() {


I'm wondering if we can solve this the same way that I want to solve the fake provider — that is, instead of extending from a block tracker class, have a class that fulfills the block tracker interface. You're right that that would be a separate change though. This is fine for now — thanks for clarifying.

--------- Co-authored-by: Elliot Winkler <[email protected]>

mcmire · 2023-10-12T19:20:02Z

packages/network-controller/tests/NetworkController.test.ts

@@ -6957,7 +6957,7 @@ function buildFakeClient(
      rpcUrl: 'https://test.network',
    },
    provider,
-    blockTracker: new FakeBlockTracker(),
+    blockTracker: new FakeBlockTracker() as BlockTracker,


@MajorLift This is an example of us needing to use a type assertion. I guess the type of FakeBlockTracker isn't quite right here and doesn't match the type of blockTracker that NetworkClient demands.

@mcmire This seems like it's either been fixed or wasn't needed in the first place: #1833. These silent false negatives are the worse thing about type assertions IMO.

In general, when encountering "not assignable to" errors, I would like the underlying types to be reconciled/aligned, at least eventually. Are there maybe "usual suspect" entities in our codebase that I can assume it'll be safe to use type assertion on?

## Explanation This PR implements the following incremental steps in the process for migrating `eth-json-rpc-provider` into the core monorepo: *** ### Phase B: Staging from `merged-packages/` #### 5. Port tags - See: #1800 <details> <summary>Push ported tags to core repo</summary> - [x] https://github.com/MetaMask/core/releases/tag/@metamask/[email protected] - [x] https://github.com/MetaMask/core/releases/tag/@metamask/[email protected] - [x] https://github.com/MetaMask/core/releases/tag/@metamask/[email protected] - [x] https://github.com/MetaMask/core/releases/tag/@metamask/[email protected] - [x] https://github.com/MetaMask/core/releases/tag/@metamask/[email protected] </details> <details> <summary>Verify that the tag diff links in CHANGELOG are working</summary> - [x] **WONTFIX**: https://github.com/MetaMask/core/compare/@metamask/[email protected] - [x] https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] - [x] https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] - [x] https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] - [x] https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] </details> ### Phase C: Integration into `packages/` #### 1. The big leap - [x] **Move migration target from `migrated-packages/` to `packages/`.** - [x] Run `yarn install` in the root directory. - [x] Check that all tests are passing in migration target by running `yarn workspace @metamask/<package-name> test`. #### 2. Update downstream repos - [x] Add tsconfig reference paths for migration target in downstream packages and root. - [x] Bump migration target version in downstream packages and root. #### 3. Linter fixes - [x] Apply yarn constraints fixes to migration target package.json file: `yarn constraints --fix` (run twice). - [x] Identify validator fixes for CHANGELOG using `yarn workspace @metamask/<package-name> changelog:validate` and apply the diffs. #### 4. Resolve downstream errors - [x] #1653 - If introducing the migration target breaks any downstream repos: - [x] Resolve simple errors - [x] Mark and ignore complex errors using `@ts-expect-error TODO:` annotations. - [x] Create a separate issue for resolving the marked errors as soon as the migration is completed. #### 5. Finalize merge - [x] Check that all tests are passing in all subpackages of core and CI. - [x] Merge `packages/<package-name>` directory into core main branch. *** See #1551 (comment) for an outline of the entire process. ## Next Steps - The next PR(s) will implement the final steps of the migration process (D-1 in the migration checklist). ## Blocked by - Dependencies: - [x] typescript bump: #1718 - [x] `@metamask/utils` bump: #1639 - Downstream type errors: - [x] #1653 - [ ] MetaMask/eth-json-rpc-provider#14 (ignored) - [ ] MetaMask/utils#140 (ignored) - Tag porting: - [x] #1802 - [x] "Unreleased" tag diff link shows entire history of core: https://github.com/MetaMask/core/compare/@metamask/[email protected] ## References - Contributes to #1685 - Contributes to #1551 ## Changelog  ### `@metamask/eth-json-rpc-provider` - **ADDED**: Migrated into the core monorepo. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

legobeat marked this pull request as ready for review September 1, 2023 23:47

legobeat requested review from a team as code owners September 1, 2023 23:47

legobeat changed the title ~~bump metamask dependencies~~ deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors,utils} Sep 1, 2023

legobeat added the dependencies Pull requests that update a dependency file label Sep 1, 2023

legobeat force-pushed the deps-metamask-bumps-202309 branch from bc0d221 to 5972103 Compare September 5, 2023 06:09

legobeat mentioned this pull request Sep 5, 2023

Bump @metamask/utils from 6.2.0 to 8.1.0 #1648

Closed

legobeat force-pushed the deps-metamask-bumps-202309 branch from 5972103 to 4610873 Compare September 5, 2023 13:37

legobeat requested review from vinistevam and a team September 6, 2023 09:02

legobeat force-pushed the deps-metamask-bumps-202309 branch 2 times, most recently from 3bc848a to f530b96 Compare September 8, 2023 09:59

legobeat mentioned this pull request Sep 9, 2023

deps: Update @metamask/utils and @metamask/rpc-errors MetaMask/snaps#1728

Closed

34 tasks

legobeat marked this pull request as draft September 10, 2023 02:44

legobeat force-pushed the deps-metamask-bumps-202309 branch from f530b96 to f081410 Compare September 10, 2023 02:49

legobeat force-pushed the deps-metamask-bumps-202309 branch 2 times, most recently from 9161c19 to 91e5cfa Compare September 13, 2023 21:40

legobeat and others added 10 commits October 11, 2023 07:24

devDeps: json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engine@^7.1.1

7eaa056

deps(network-controller): @metamask/eth-json-rpc-middleware@^11.0.2->…

4c36b0f

…^12.0.0

deps(network-controller): eth-block-tracker@^7.1.0->^8.0.0

573e59c

types(network-controller): change type alias BlockTracker from class …

2f689c6

…PollingBlockTracker to type BlockTracker

eth-block-tracker update

3a809ba

ignore mismatching internal eth-json-rpc provider types

8b997a6

types(network-controller): type createCustomNetworkMiddleware

e47bcc6

Revert "ignore mismatching internal eth-json-rpc provider types"

bec2646

This reverts commit bc269f5.

types: @ts-expect-error mismatching eth-json-rpc provider types

08d912c

@ts-expect eth-json-rpc provider type

d80a8d7

Co-authored-by: Elliot Winkler <[email protected]>

legobeat dismissed MajorLift’s stale review via d80a8d7 October 10, 2023 22:24

legobeat force-pushed the deps-metamask-bumps-202309 branch from 942a8e7 to d80a8d7 Compare October 10, 2023 22:24

legobeat requested review from MajorLift, FrederikBolding, Mrtenz, gantunesr and mikesposito October 11, 2023 06:56

deps: @metamask/rpc-errors@^6.0.0->^6.1.0

d1dd687

MajorLift approved these changes Oct 11, 2023

View reviewed changes

mcmire approved these changes Oct 11, 2023

View reviewed changes

Mrtenz approved these changes Oct 11, 2023

View reviewed changes

Merge branch 'main' into deps-metamask-bumps-202309

2ebfd68

legobeat merged commit 2e95c89 into MetaMask:main Oct 11, 2023
213 checks passed

MajorLift mentioned this pull request Oct 11, 2023

Fix provider type errors in NetworkController and its downstream packages #1823

Closed

MajorLift pushed a commit that referenced this pull request Oct 11, 2023

deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors} (#1653)

adc787d

--------- Co-authored-by: Elliot Winkler <[email protected]>

MajorLift pushed a commit that referenced this pull request Oct 11, 2023

deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors} (#1653)

11461ed

--------- Co-authored-by: Elliot Winkler <[email protected]>

mcmire reviewed Oct 12, 2023

View reviewed changes

MajorLift mentioned this pull request Oct 12, 2023

Remove as assertion casting FakeBlockTracer to BlockTracker #1833

Merged

3 tasks

legobeat deleted the deps-metamask-bumps-202309 branch October 12, 2023 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: Bump `@metamask/{eth-json-rpc-provider,rpc-errors}` #1653

deps: Bump `@metamask/{eth-json-rpc-provider,rpc-errors}` #1653

legobeat commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 8, 2023 •

edited

Loading

legobeat commented Sep 8, 2023

legobeat commented Sep 10, 2023

mcmire left a comment

mcmire Oct 11, 2023 •

edited

Loading

mcmire Oct 12, 2023

MajorLift Oct 12, 2023

deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors} #1653

deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors} #1653

Conversation

legobeat commented Sep 1, 2023 • edited Loading

Explanation

References

Blocked by

Blocking

socket-security bot commented Sep 1, 2023 • edited Loading

socket-security bot commented Sep 8, 2023 • edited Loading

legobeat commented Sep 8, 2023

legobeat commented Sep 10, 2023

mcmire left a comment

Choose a reason for hiding this comment

mcmire Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

mcmire Oct 12, 2023

Choose a reason for hiding this comment

MajorLift Oct 12, 2023

Choose a reason for hiding this comment

deps: Bump `@metamask/{eth-json-rpc-provider,rpc-errors}` #1653

deps: Bump `@metamask/{eth-json-rpc-provider,rpc-errors}` #1653

legobeat commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 8, 2023 •

edited

Loading

mcmire Oct 11, 2023 •

edited

Loading