eth-json-rpc-provider migration - B2: Replace typescript, jest config files.
#1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orepo root - preserved project-specific compiler options
… root and add `deepmerge` as dependency
mcmire
reviewed
Oct 5, 2023
MajorLift
commented
Oct 5, 2023
mcmire
approved these changes
Oct 5, 2023
15 tasks
MajorLift
added a commit
that referenced
this pull request
Oct 12, 2023
…ig files. (#1765) ## Explanation This PR implements the following incremental step in the process for migrating `eth-json-rpc-provider` into the core monorepo: *** ### Phase B: Staging in `migrated-packages/` #### 2. Replace config files. - [x] Update `tsconfig*.json`, `typedoc.json`, `jest.config.js` to extend from corresponding files in root. Copy contents of corresponding files in other non-root packages. - [x] Keep TypeScript compiler flags. - [x] Add tsconfig reference paths for non-root packages that are upstream dependencies of the migration target. - [x] Keep Jest coverage threshold values. - [x] Add `deepmerge` as a devDependency. *** See #1551 (comment) for an outline of the entire process. ## References - Contributes to #1685 - Contributes to #1551 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements the following incremental step in the process for migrating
eth-json-rpc-providerinto the core monorepo:Phase B: Staging in
migrated-packages/2. Replace config files.
tsconfig*.json,typedoc.json,jest.config.jsto extend from corresponding files in root. Copy contents of corresponding files in other non-root packages.deepmergeas a devDependency.See #1551 (comment) for an outline of the entire process.
References
@metamask/eth-json-rpc-providerto core monorepo #1685eth-json-rpc-providerinto core monorepo #1551Changelog
N/A
Checklist