Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-rpc-engine: Update tsconfig*.json, typedoc.json, jest.config.js to align with repo defaults #1878

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

kanthesha
Copy link
Contributor

@kanthesha kanthesha commented Oct 20, 2023

Explanation

In the process of migrating json-rpc-engine to core monorepo. In this PR, we have updated tsconfig*.json, typedoc.json, jest.config.js to extend from corresponding files in the core root directory.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@kanthesha kanthesha marked this pull request as ready for review October 20, 2023 15:55
@kanthesha kanthesha requested a review from a team as a code owner October 20, 2023 15:55
mcmire
mcmire previously approved these changes Oct 20, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with a branch that brings json-rpc-engine into packages/, and this seems to work.

@legobeat legobeat changed the title Updated tsconfig*.json, typedoc.json, jest.config.js to align with co… json-rpc-engine: Update tsconfig*.json, typedoc.json, jest.config.js to align with repo defaults Oct 20, 2023
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fb81f3b needs to be reverted.

merged-packages/json-rpc-engine/tsconfig.json Outdated Show resolved Hide resolved
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author @metamask/eth-simple-keyring 5.1.1
Unstable ownership @metamask/eth-simple-keyring 5.1.1

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@kanthesha kanthesha self-assigned this Oct 23, 2023
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kanthesha kanthesha merged commit bc4aaad into main Oct 23, 2023
110 of 111 checks passed
@kanthesha kanthesha deleted the update-json-rpc-engine-configs branch October 23, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants