-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record CHANGELOG entries from @metamask/json-rpc-{engine,middleware-stream}
migrations
#2003
Merged
MajorLift
merged 11 commits into
main
from
231107-record-changelog-migrations-json-rpc-engine,middleware-stream
Nov 8, 2023
Merged
Record CHANGELOG entries from @metamask/json-rpc-{engine,middleware-stream}
migrations
#2003
MajorLift
merged 11 commits into
main
from
231107-record-changelog-migrations-json-rpc-engine,middleware-stream
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss core subpackages - Update in `NetworkController` already recorded in https://github.com/MetaMask/core/releases/tag/v88.0.0
MajorLift
force-pushed
the
231107-record-changelog-migrations-json-rpc-engine,middleware-stream
branch
2 times, most recently
from
November 7, 2023 19:41
f7237f6
to
a81dcf5
Compare
MajorLift
force-pushed
the
231107-record-changelog-migrations-json-rpc-engine,middleware-stream
branch
from
November 7, 2023 20:27
91b6b62
to
fa6f2b6
Compare
…engine,middleware-stream
…engine,middleware-stream
mcmire
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few that were potentially missing.
…engine,middleware-stream
Co-authored-by: Elliot Winkler <[email protected]>
mcmire
previously approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
MajorLift
force-pushed
the
231107-record-changelog-migrations-json-rpc-engine,middleware-stream
branch
from
November 8, 2023 01:21
6bd5923
to
6a5f2f3
Compare
This was referenced Nov 8, 2023
FrederikBolding
approved these changes
Nov 8, 2023
…engine,middleware-stream
…engine,middleware-stream
MajorLift
deleted the
231107-record-changelog-migrations-json-rpc-engine,middleware-stream
branch
November 8, 2023 15:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Records CHANGELOG entries from
@metamask/json-rpc-engine
and@metamask/json-rpc-middleware-stream
migrations under "Unreleased" headers for reference during the next version release.@metamask/json-rpc-engine
and@metamask/json-rpc-middleware-stream
packages since its last release, and during the migration process.Records changes made to downstream repos.References
@metamask/json-rpc-engine
#1981@metamask/json-rpc-middleware-stream
#1982Changelog
N/A
Checklist