-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process guide for migrating packages into the core monorepo #2071
Conversation
d5bfdb5
to
d6b1aa7
Compare
d6b1aa7
to
efa1d2f
Compare
efa1d2f
to
76aa46d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of PRs to have to create for one package 😅 But it all makes sense, and it's nice that many of the PRs will be small.
Thanks for putting this together. This looks really comprehensive. I just had a few suggestions.
Co-authored-by: Elliot Winkler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Nice to see that you also have a detailed preparation phase to outline the steps to be performed prior to the migration, and that there are plenty of example PRs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing but otherwise I think this is ready to go!
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Explanation
This document outlines the process for migrating a MetaMask library into the core monorepo. The migration target is assumed to comply with the requirements defined by
metamask-module-template
andmodule-lint
.References
Changelog
N/A
Checklist