-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Broken CSS Export in Design Tokens Package #609
Conversation
@@ -81,7 +81,7 @@ gen_enforced_field(WorkspaceCwd, 'exports["./package.json"]', './package.json'). | |||
|
|||
% The list of files included in the package must only include files generated | |||
% during the build step. | |||
gen_enforced_field(WorkspaceCwd, 'files', ['dist']). | |||
gen_enforced_field(WorkspaceCwd, 'files', ['dist', 'src/css/']). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lints the package.json folder when running yarn lint
@@ -27,7 +27,8 @@ | |||
"module": "./dist/index.mjs", | |||
"types": "./dist/types/index.d.ts", | |||
"files": [ | |||
"dist" | |||
"dist", | |||
"src/css/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally how we had it before v2 update https://github.com/MetaMask/design-tokens/pull/601/files#r1476736756
Description
This PR addresses the issue of the broken CSS export in the design tokens package that occurred after the v2 release. The fix ensures that the CSS export functions correctly and can be used without issues in projects that depend on it.
Related issues
Fixes: #608
Manual testing steps
npm pack
this creates a tarball of the same format that would be sent to the registryScreenshots/Recordings
Before
Running
npm pack
before updatebefore.mov
After
Running
npm pack
after update and inspecting folderafter.mov
Pre-merge author checklist
Pre-merge reviewer checklist