Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate tokens with style dictionary #615

Closed
wants to merge 7 commits into from

Conversation

garrettbear
Copy link
Contributor

@garrettbear garrettbear commented Feb 7, 2024

Description

To run: node style-dictionary-build.js

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Feb 7, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@bundled-es-modules/[email protected] None +1 37.8 kB jorenbroekema
npm/@bundled-es-modules/[email protected] Transitive: environment, eval, filesystem, shell +92 5.36 MB jorenbroekema
npm/@bundled-es-modules/[email protected] environment, eval +42 10.8 MB jorenbroekema
npm/@tokens-studio/[email protected] Transitive: environment, eval, filesystem, shell +131 23.4 MB andrewattokensstudio, jorenbroekema, lukefinch, ...2 more
npm/@tokens-studio/[email protected] None 0 42.3 kB andrewattokensstudio, jorenbroekema, lukefinch, ...2 more
npm/@yarnpkg/[email protected] environment, eval, filesystem 0 280 kB arcanis
npm/[email protected] None 0 13.7 kB leerobinson
npm/[email protected] None 0 2.63 kB ryanzim
npm/[email protected] None +2 108 kB feross
npm/[email protected] None +4 147 kB blakeembrey
npm/[email protected] None 0 35.2 kB blakeembrey
npm/[email protected] None 0 293 kB ricokahler
npm/[email protected] None 0 1.93 MB leaverou
npm/[email protected] None +4 153 kB blakeembrey
npm/[email protected] None 0 10.5 kB sindresorhus
npm/[email protected] None 0 146 kB jorenbroekema
npm/[email protected] filesystem +6 261 kB bmishkin
npm/[email protected] None +5 158 kB blakeembrey
npm/[email protected] None 0 861 kB streamich
npm/[email protected] None 0 2.25 kB tehshrike
npm/[email protected] None 0 3.43 kB juliangruber
npm/[email protected] None +4 8.52 MB streamich
npm/[email protected] Transitive: eval +13 280 kB ljharb
npm/[email protected] None 0 210 kB vscode-bot
npm/[email protected] None 0 19.4 kB ljharb
npm/[email protected] Transitive: environment, filesystem +1 43 kB manidlou
npm/[email protected] None +5 9.43 MB streamich
npm/[email protected] environment, filesystem, shell +2 48.7 kB sindresorhus
npm/[email protected] None 0 3.06 kB sindresorhus
npm/[email protected] environment, filesystem Transitive: eval, shell +52 1.72 MB ds300
npm/[email protected] None +4 147 kB blakeembrey
npm/[email protected] environment 0 64.3 kB jorenbroekema
npm/[email protected] environment +3 56.1 kB jinder
npm/[email protected] None +1 94.7 kB ota-meshi
npm/[email protected] None +4 148 kB blakeembrey
npm/[email protected] None +4 148 kB blakeembrey
npm/[email protected] None +1 22.5 kB juliangruber
npm/[email protected] filesystem Transitive: environment, shell +53 9.32 MB dbanksdesign
npm/[email protected] None +1 174 kB streamich
npm/[email protected] None 0 285 kB bgrins
npm/[email protected] filesystem +1 29.1 kB raszi
npm/[email protected] None +1 92.8 kB blakeembrey
npm/[email protected] None +1 99.6 kB blakeembrey

View full report↗︎

Copy link

socket-security bot commented Feb 7, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/[email protected]
New author npm/[email protected]
  • New Author: ljharb
  • Previous Author:
New author npm/[email protected]
New author npm/[email protected]
New author npm/[email protected]
Install scripts npm/@bundled-es-modules/[email protected]
New author npm/[email protected]
Install scripts npm/[email protected]

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@georgewrmarshall
Copy link
Collaborator

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants