Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating dependencies #739

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: updating dependencies #739

merged 1 commit into from
Nov 5, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

Description

This PR updates dependencies to resolve build failures in the Compatibility test (20.x) job. The current failure is due to missing configuration for dependencies, specifically an issue flagged by @lavamoat/allow-scripts regarding dependencies that require explicit configuration. By updating the necessary packages and adjusting configurations, this PR aims to ensure compatibility with the latest Node.js (20.x) environment and prevent similar issues in future CI runs.

Related Issues

N/A

Manual Testing Steps

  1. Run yarn install locally to ensure dependencies are correctly installed.
  2. Execute the compatibility test suite for Node.js 20.x to confirm the issue is resolved.
  3. Verify that no configuration warnings appear during the build and that all tests pass.

Pre-merge Author Checklist

  • Updated necessary dependencies in package.json and/or yarn.lock.
  • Verified successful local builds and tests with updated dependencies.
  • Ensured that the compatibility test (20.x) job passes in the CI pipeline.

Pre-merge Reviewer Checklist

  • Confirmed that dependencies were updated without introducing breaking changes.
  • Verified that the CI compatibility test (20.x) passes without errors.
  • Confirmed no unresolved configuration warnings during dependency installation.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Nov 5, 2024
@georgewrmarshall georgewrmarshall self-assigned this Nov 5, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review November 5, 2024 01:58
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 5, 2024 01:58
Copy link

socket-security bot commented Nov 5, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/@types/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/[email protected], npm/@lavamoat/[email protected], npm/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/[email protected], npm/[email protected], npm/@mdx-js/[email protected], npm/[email protected], npm/@vitejs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/[email protected], npm/@types/[email protected], npm/[email protected], npm/@rollup/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/[email protected], npm/@eslint-community/[email protected], npm/[email protected], npm/@eslint-community/[email protected], npm/@vitest/[email protected], npm/@vitest/[email protected], npm/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/[email protected], npm/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@types/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@georgewrmarshall
Copy link
Collaborator Author

georgewrmarshall commented Nov 5, 2024

@SocketSecurity ignore-all

Acceptable risk as we are protected from supply chain attacks by lavamoat

Screenshot 2024-11-04 at 6 00 16 PM

Copy link

Report too large to display inline

View full report↗︎

@georgewrmarshall
Copy link
Collaborator Author

I realize the storybook job is failing created an issue here #740

@georgewrmarshall georgewrmarshall merged commit 8586fb7 into main Nov 5, 2024
18 of 19 checks passed
@georgewrmarshall georgewrmarshall deleted the update/dependencies branch November 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants