This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
fix: disconnect error during transport reset (iOS devices only) #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort, and because eth app hasn't been recreated with new transport even that transport has exactly same property (android will not throw error, only ios did)
7 tasks
gantunesr
changed the title
gantunesr
reviewed
Jul 9, 2024
Co-authored-by: Gustavo Antunes <[email protected]>
…iption and follow metamask unit tests guideline
gantunesr
approved these changes
Jul 10, 2024
Gudahtt
reviewed
Jul 12, 2024
| @@ -60,9 +58,6 @@ export class LedgerTransportMiddleware implements TransportMiddleware { | |||
| * @returns An generic interface for communicating with a Ledger hardware wallet to perform operation. | |||
| */ | |||
| getEthApp(): MetaMaskLedgerHwAppEth { | |||
| if (!this.#app) { | |||
There was a problem hiding this comment.
The comment above is now inaccurate: "it create a new eth app instance if not exist."
We should fix that in a follow up PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in iOS devices a disconnect error will be thrown when trying to reset the transport object. The reason for this is because the ETH app hasn't been recreated with the new transport object, even though the transport has the same properties as the previous one.
Note: We do not see this in Android devices, the setup and communication will work correctly without the need to reset the transport object.